kernel: poll: Allow 0 events for submitted work #83829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-mitsis
previously approved these changes
Jan 10, 2025
andyross
previously approved these changes
Jan 11, 2025
cfriedt
previously approved these changes
Jan 11, 2025
jukkar
reviewed
Jan 13, 2025
| @@ -675,7 +675,7 @@ int k_work_poll_submit_to_queue(struct k_work_q *work_q, | |||
| __ASSERT(work_q != NULL, "NULL work_q\n"); | |||
There was a problem hiding this comment.
Typo in commit msg, s/artivical/artificial/
kernel/poll.c
Outdated
| @@ -675,7 +675,7 @@ int k_work_poll_submit_to_queue(struct k_work_q *work_q, | |||
| __ASSERT(work_q != NULL, "NULL work_q\n"); | |||
| __ASSERT(work != NULL, "NULL work\n"); | |||
| __ASSERT(events != NULL, "NULL events\n"); | |||
| __ASSERT(num_events > 0, "zero events\n"); | |||
| __ASSERT(num_events >= 0, "zero events\n"); | |||
There was a problem hiding this comment.
Isn't the message now a bit misleading as we allow zero events, should this be something like invalid event count or similar?
Change:
commit cc6317d
Author: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Date: Fri Nov 1 14:03:32 2019 +0200
kernel: poll: Allow 0 event input
Allows `k_poll` to be user with 0 events, which is useful for allowing just
a sleep without having to create artificial events.
Allow the same for `k_work_submit_to_queue()` and `k_work_submit()`.
Signed-off-by: David Brown <david.brown@linaro.org>
244d60a
kartben
approved these changes
Jan 15, 2025
jukkar
approved these changes
Jan 16, 2025
nashif
approved these changes
Jan 16, 2025
cfriedt
approved these changes
Jan 16, 2025
|
@andyross @peter-mitsis refresh +1? Thanks! 😊 |
peter-mitsis
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change:
commit cc6317d
Author: Jukka Rissanen jukka.rissanen@linux.intel.com
Date: Fri Nov 1 14:03:32 2019 +0200
Allows
k_pollto be user with 0 events, which is useful for allowing just a sleep without having to create artivical events.Allow the same for
k_work_submit_to_queue()andk_work_submit().