drivers: regulator: npm1300: workaround for LDO HW bug #83790
Conversation
| ldo-workaround-enabled: | ||
| type: boolean | ||
| description: | | ||
| Enable a SW workaround for LDO bug. | ||
| When nPM1300 is in ULP mode, LDO is supplied from VSYS and | ||
| then LDO is enabled, it can take long time until the LDO | ||
| output has reached its target voltage. To avoid this, an i2c | ||
| read is performed shortly after an LDO is enabled. |
There was a problem hiding this comment.
why is DT involved here? Shouldn't this always be enabled as needed?
There was a problem hiding this comment.
This bug shows itself only in a very specific case. We cannot know whether this case is present since it involves HW design choices. It is enabled by default to be on a safe side, but if developers know that they don't run into this corner case they can avoid a redundant operation disabling this behavior.
There was a problem hiding this comment.
So if enabled by default, change the property like this:
nordic,ldo-disable-...
Also, calling this "SW workaround for LDO" feels too generic, is there any associated PAN?
There was a problem hiding this comment.
PAN/ERRATA is coming soon, would it be okay to add a reference to it later? We'd really like to have a fix in place even without a reference for the time being
There is a HW bug in nPM1300 LDO which causes the LDO output voltage to reach its target very slowly in specific cases. This is worked around by performing an additional i2c read shortly after an LDO is enabled. Signed-off-by: Sergei Ovchinnikov <sergei.ovchinnikov@nordicsemi.no>
5a3f9a6 to
0c37a3f
Compare
There is a HW bug in nPM1300 LDO which causes the LDO output voltage to reach its target very slowly in specific cases. This is worked around by performing an additional i2c read shortly after an LDO is enabled.