Bluetooth: TBS: Ensure sending notifications #82775
Draft
+743
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6487dce to
36b1833
Compare
bd56fe6 to
a3cf21a
Compare
The existing implemented only attempted to send all notifications, but if host was out of ATT TX buffers the notifications would fail and the client may miss out on important information, and would be a spec violation. This commit refactors notificatios in TBS so that they are always sent. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
a3cf21a to
873f780
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implemented only attempted to send all notifications, but if host was out of ATT TX buffers the notifications would fail and the client may miss out on important information, and would be a spec violation.
This commit refactors notificatios in TBS so that they are always sent.