samples: lora: receive: update SNR unit to dB #82451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ya, that can be confusing. I'll try to take care of this |
martinjaeger
previously approved these changes
Dec 3, 2024
kartben
requested changes
Dec 3, 2024
kartben
reviewed
Dec 3, 2024
| @@ -28,8 +28,8 @@ void lora_receive_cb(const struct device *dev, uint8_t *data, uint16_t size, | |||
| ARG_UNUSED(dev); | |||
| ARG_UNUSED(size); | |||
|
|
|||
| LOG_INF("Received data: %s (RSSI:%ddBm, SNR:%ddBm)", | |||
| data, rssi, snr); | |||
| LOG_INF("LoRa RX RSSI: %ddBm, SNR: %ddB", rssi, snr); | |||
There was a problem hiding this comment.
nit: also, please add a space between number and unit as per SI rules.
|
updated log output (with the spaces between numbers and units) .. code-block:: console
[00:00:00.235,000] <inf> lora_receive: Synchronous reception
[00:00:00.956,000] <inf> lora_receive: LoRa RX RSSI: -60dBm, SNR: 7dB
[00:00:00.956,000] <inf> lora_receive: LoRa RX payload
68 65 6c 6c 6f 77 6f 72 6c 64 |hellowor ld
[00:00:02.249,000] <inf> lora_receive: LoRa RX RSSI: -57dBm, SNR: 9dB
[00:00:02.249,000] <inf> lora_receive: LoRa RX payload
68 65 6c 6c 6f 77 6f 72 6c 64 |hellowor ld
[00:00:03.541,000] <inf> lora_receive: LoRa RX RSSI: -57dBm, SNR: 9dB
[00:00:03.541,000] <inf> lora_receive: LoRa RX payload
68 65 6c 6c 6f 77 6f 72 6c 64 |hellowor ld
[00:00:04.834,000] <inf> lora_receive: LoRa RX RSSI: -55dBm, SNR: 9dB
[00:00:04.834,000] <inf> lora_receive: LoRa RX payload
68 65 6c 6c 6f 77 6f 72 6c 64 |hellowor ld
[00:00:04.834,000] <inf> lora_receive: Asynchronous reception
[00:00:06.127,000] <inf> lora_receive: LoRa RX RSSI: -55dBm, SNR: 9dB
[00:00:06.127,000] <inf> lora_receive: LoRa RX payload
68 65 6c 6c 6f 77 6f 72 6c 64 |hellowor ld
[00:00:07.419,000] <inf> lora_receive: LoRa RX RSSI: -55dBm, SNR: 9dB
[00:00:07.419,000] <inf> lora_receive: LoRa RX payload
68 65 6c 6c 6f 77 6f 72 6c 64 |hellowor ld
[00:00:08.712,000] <inf> lora_receive: LoRa RX RSSI: -55dBm, SNR: 9dB
[00:00:08.712,000] <inf> lora_receive: LoRa RX payload
68 65 6c 6c 6f 77 6f 72 6c 64 |hellowor ld
[00:00:10.004,000] <inf> lora_receive: LoRa RX RSSI: -55dBm, SNR: 9dB
[00:00:10.004,000] <inf> lora_receive: LoRa RX payload
68 65 6c 6c 6f 77 6f 72 6c 64 |hellowor ld
[00:00:11.297,000] <inf> lora_receive: LoRa RX RSSI: -55dBm, SNR: 9dB
[00:00:11.297,000] <inf> lora_receive: LoRa RX payload
68 65 6c 6c 6f 77 6f 72 6c 64 |hellowor ld
[00:00:12.590,000] <inf> lora_receive: LoRa RX RSSI: -55dBm, SNR: 9dB
[00:00:12.590,000] <inf> lora_receive: LoRa RX payload
68 65 6c 6c 6f 77 6f 72 6c 64 |hellowor ld
[00:00:13.884,000] <inf> lora_receive: LoRa RX RSSI: -55dBm, SNR: 9dB
[00:00:13.884,000] <inf> lora_receive: LoRa RX payload
68 65 6c 6c 6f 77 6f 72 6c 64 |hellowor ld
[00:00:15.177,000] <inf> lora_receive: LoRa RX RSSI: -55dBm, SNR: 9dB
[00:00:15.177,000] <inf> lora_receive: LoRa RX payload
68 65 6c 6c 6f 77 6f 72 6c 64 |hellowor ld
[00:00:16.470,000] <inf> lora_receive: LoRa RX RSSI: -55dBm, SNR: 9dB
[00:00:16.470,000] <inf> lora_receive: LoRa RX payload
68 65 6c 6c 6f 77 6f 72 6c 64 |hellowor ld
[00:00:17.762,000] <inf> lora_receive: LoRa RX RSSI: -55dBm, SNR: 9dB
[00:00:17.762,000] <inf> lora_receive: LoRa RX payload
68 65 6c 6c 6f 77 6f 72 6c 64 |hellowor ld
[00:00:17.762,000] <inf> lora_receive: Stopping packet receptions |
a25b18f to
6501f8c
Compare
kartben
previously approved these changes
Dec 3, 2024
Signal-to-noise ratio is a unitless quantity, so its unit is dB, not dBm (dBm is the power relative to 1 milliwatt). At the same time output the received payload using `LOG_HEXDUMP_INF`, instead of limiting the sample solely to string payloads. Fixes zephyrproject-rtos#82414 Signed-off-by: Jordan Yates <jordan@embeint.com>
6501f8c to
a2e8e8c
Compare
kartben
approved these changes
Dec 3, 2024
mniestroj
approved these changes
Dec 3, 2024
martinjaeger
approved these changes
Dec 3, 2024
kartben
reviewed
Dec 17, 2024
| LOG_INF("Received data: %s (RSSI:%ddBm, SNR:%ddBm)", | ||
| data, rssi, snr); | ||
| LOG_INF("LoRa RX RSSI: %d dBm, SNR: %d dB", rssi, snr); | ||
| LOG_HEXDUMP_INF(data, size, "LoRa RX payload"); |
There was a problem hiding this comment.
Suggested change
| LOG_HEXDUMP_INF(data, size, "LoRa RX payload"); | |
| LOG_HEXDUMP_INF(data, len, "LoRa RX payload"); |
@JordanYates caught in weekly CI run. Could you please fix this compilation issue (and possibly look at adding an integration platform for the sample so that it doesn't happen again? Applies to both LoRa samples and likely LoRaWAN samples too?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signal-to-noise ratio is a unitless quantity, so its unit is dB, not dBm (dBm is the power relative to 1 milliwatt). At the same time output the received payload using
LOG_HEXDUMP_INF, instead of limiting the sample solely to string payloads.Fixes #82414
Ideally this would also update the README sample output, but I no longer have access to any hardware with a LoRa modem to regenerate it.