-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: st: introduce new stm32f413 disco kit #82275
Conversation
81aa2a0
to
f8872c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
although fixing the images for existing ST boards would generate more harm than good as this would just clutter the repo, can I please ask that you guys try to provide images that don't have Mbed logo in them going forward? :) // cc @erwango
I would take this one (note that it's effectively a .webp image --which is perfect-- not .png, so please name file accordingly) https://www.mouser.fr/images/marketingid/2017/img/128173244_STMicroelectronics_32F413HDISCOVERYDiscoveryKit.png?v=070223.0256
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
taking that image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You didn't? Would be great, as it's transparent, contrary to the jpeg you used.
f8872c4
to
1ef2f98
Compare
1ef2f98
to
8fbb6fa
Compare
@FRASTM please check the CI failures |
8fbb6fa
to
706d6be
Compare
706d6be
to
f0fd906
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You didn't? Would be great, as it's transparent, contrary to the jpeg you used.
f0fd906
to
168bfe8
Compare
with new image and new 1 commit |
I'm not sure what's going on but can't you just use: |
that's the case : the webp image I put, was processed by https://tinypng.com/ but it seems it does not have the transparent background (I do not know exactly the command to obtain that effect) . Does it really make a difference ? |
but why don't you want to use the one I linked to? It falls under fair-use, if that's your concern. |
168bfe8
to
6ee5616
Compare
taking the recommended image |
Thanks! https://builds.zephyrproject.io/zephyr/pr/82275/docs/boards/st/stm32f413h_disco/doc/index.html :) |
@FRASTM sample.bluetooth.peripheral_hr.frdm_kw41z_shield build failure in CI
|
rebase on main will fix the issue |
Fix the board name in the stm32F412g_disco index description file Signed-off-by: Francois Ramu <francois.ramu@st.com>
Add the stm32f413h_disco target to the boards/st Add the PLLi2S when needed by the USB or SDMMC or RNG. Signed-off-by: Francois Ramu <francois.ramu@st.com>
6ee5616
to
4735d7b
Compare
Done |
Add the stm32f413h_disco target to the boards/st
Add the PLL I2S if the clock 48MHz is required as a source clock by the SDMMC or USB or RNG
this PLLI2S is of compatible = "st,stm32f412-plli2s-clock"; introduced by the #82259
https://www.st.com/en/evaluation-tools/32f413hdiscovery.html