Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: st: introduce new stm32f413 disco kit #82275

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

FRASTM
Copy link
Collaborator

@FRASTM FRASTM commented Nov 28, 2024

Add the stm32f413h_disco target to the boards/st

Add the PLL I2S if the clock 48MHz is required as a source clock by the SDMMC or USB or RNG
this PLLI2S is of compatible = "st,stm32f412-plli2s-clock"; introduced by the #82259

/* Enable PLL I2S to Deliver 48MHz clock from HS Clock */
&plli2s {
	div-m = <4>;
	mul-n = <96>;
	div-q = <4>;
	div-r = <2>;
	clocks = <&clk_hse>;
	status = "okay";
};

https://www.st.com/en/evaluation-tools/32f413hdiscovery.html

@FRASTM FRASTM force-pushed the stm32f413h_disco branch 3 times, most recently from 81aa2a0 to f8872c4 Compare November 28, 2024 17:07
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although fixing the images for existing ST boards would generate more harm than good as this would just clutter the repo, can I please ask that you guys try to provide images that don't have Mbed logo in them going forward? :) // cc @erwango
I would take this one (note that it's effectively a .webp image --which is perfect-- not .png, so please name file accordingly) https://www.mouser.fr/images/marketingid/2017/img/128173244_STMicroelectronics_32F413HDISCOVERYDiscoveryKit.png?v=070223.0256

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

taking that image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't? Would be great, as it's transparent, contrary to the jpeg you used.

boards/st/stm32f413h_disco/board.cmake Outdated Show resolved Hide resolved
boards/st/stm32f413h_disco/stm32f413h_disco_defconfig Outdated Show resolved Hide resolved
boards/st/stm32f413h_disco/doc/index.rst Outdated Show resolved Hide resolved
boards/st/stm32f413h_disco/doc/index.rst Outdated Show resolved Hide resolved
@FRASTM FRASTM added DNM This PR should not be merged (Do Not Merge) platform: STM32 ST Micro STM32 labels Nov 29, 2024
@FRASTM FRASTM marked this pull request as ready for review December 6, 2024 16:04
@FRASTM FRASTM requested review from nordicjm and kartben December 6, 2024 16:05
@kartben
Copy link
Collaborator

kartben commented Dec 11, 2024

@FRASTM please check the CI failures

@FRASTM
Copy link
Collaborator Author

FRASTM commented Dec 12, 2024

rebase on 7c4abb1 : CI error due to #82344

@FRASTM FRASTM removed the DNM This PR should not be merged (Do Not Merge) label Dec 12, 2024
boards/st/stm32f413h_disco/doc/index.rst Outdated Show resolved Hide resolved
boards/st/stm32f413h_disco/doc/index.rst Outdated Show resolved Hide resolved
boards/st/stm32f413h_disco/doc/index.rst Outdated Show resolved Hide resolved
@FRASTM FRASTM requested a review from JarmouniA December 12, 2024 16:12
boards/st/stm32f412g_disco/doc/index.rst Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't? Would be great, as it's transparent, contrary to the jpeg you used.

@FRASTM
Copy link
Collaborator Author

FRASTM commented Dec 18, 2024

with new image and new 1 commit

@kartben
Copy link
Collaborator

kartben commented Dec 18, 2024

with new image and new 1 commit

I'm not sure what's going on but can't you just use:
https://www.mouser.fr/images/marketingid/2017/img/128173244_STMicroelectronics_32F413HDISCOVERYDiscoveryKit.png?v=070223.0256 ? The image you have in your latest commit appears to be webp, sure, but without a transparent background as if you had converted your jpg image or something?

@FRASTM
Copy link
Collaborator Author

FRASTM commented Dec 18, 2024

with new image and new 1 commit

I'm not sure what's going on but can't you just use: https://www.mouser.fr/images/marketingid/2017/img/128173244_STMicroelectronics_32F413HDISCOVERYDiscoveryKit.png?v=070223.0256 ? The image you have in your latest commit appears to be webp, sure, but without a transparent background as if you had converted your jpg image or something?

that's the case : the webp image I put, was processed by https://tinypng.com/ but it seems it does not have the transparent background (I do not know exactly the command to obtain that effect) . Does it really make a difference ?
I'd really prefer to have the webp format of this one :
stm32f413_disco

@kartben
Copy link
Collaborator

kartben commented Dec 18, 2024

with new image and new 1 commit

I'm not sure what's going on but can't you just use: mouser.fr/images/marketingid/2017/img/128173244_STMicroelectronics_32F413HDISCOVERYDiscoveryKit.png?v=070223.0256 ? The image you have in your latest commit appears to be webp, sure, but without a transparent background as if you had converted your jpg image or something?

that's the case : the webp image I put, was processed by tinypng.com but it seems it does not have the transparent background (I do not know exactly the command to obtain that effect) . Does it really make a difference ?

but why don't you want to use the one I linked to? It falls under fair-use, if that's your concern.
The image with the mbed logo is really not an option IMO, for just so many reasons, including the fact that we're Zephyr and that Mbed is EOL :)

@FRASTM
Copy link
Collaborator Author

FRASTM commented Dec 18, 2024

taking the recommended image

@kartben
Copy link
Collaborator

kartben commented Dec 19, 2024

@JarmouniA
Copy link
Collaborator

@FRASTM sample.bluetooth.peripheral_hr.frdm_kw41z_shield build failure in CI

west build -p -b stm32f413h_disco/stm32f413xx samples/bluetooth/peripheral_hr -T sample.bluetooth.peripheral_hr.frdm_kw41z_shield

@kartben
Copy link
Collaborator

kartben commented Dec 20, 2024

@FRASTM sample.bluetooth.peripheral_hr.frdm_kw41z_shield build failure in CI

west build -p -b stm32f413h_disco/stm32f413xx samples/bluetooth/peripheral_hr -T sample.bluetooth.peripheral_hr.frdm_kw41z_shield

rebase on main will fix the issue

FRASTM added 2 commits January 2, 2025 09:41
Fix the board name in the stm32F412g_disco index
description file

Signed-off-by: Francois Ramu <francois.ramu@st.com>
Add the stm32f413h_disco target to the boards/st
Add the PLLi2S when needed by the USB or SDMMC or RNG.

Signed-off-by: Francois Ramu <francois.ramu@st.com>
@FRASTM
Copy link
Collaborator Author

FRASTM commented Jan 2, 2025

@FRASTM sample.bluetooth.peripheral_hr.frdm_kw41z_shield build failure in CI

west build -p -b stm32f413h_disco/stm32f413xx samples/bluetooth/peripheral_hr -T sample.bluetooth.peripheral_hr.frdm_kw41z_shield

rebase on main will fix the issue

Done

@zephyrbot zephyrbot requested a review from djiatsaf-st January 2, 2025 08:43
@kartben kartben merged commit 8b403ba into zephyrproject-rtos:main Jan 2, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants