-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CODEOWNERS: drop CODEOWNERS file as it's not used anymore #82230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartben
force-pushed
the
drop_CODEOWNERS
branch
from
November 28, 2024 12:42
7a27ba6
to
a6227ad
Compare
zephyrbot
added
area: Documentation
area: Coding Guidelines
Coding guidelines and style
area: Continuous Integration
labels
Nov 28, 2024
zephyrbot
requested review from
carlescufi,
fabiobaltieri,
jfischer-no,
keith-zephyr,
nashif,
simhein and
stephanosio
November 28, 2024 12:56
fabiobaltieri
previously approved these changes
Nov 28, 2024
simhein
previously approved these changes
Nov 28, 2024
tejlmand
previously approved these changes
Nov 29, 2024
soburi
previously approved these changes
Nov 30, 2024
MaureenHelm
previously approved these changes
Dec 2, 2024
keith-zephyr
previously approved these changes
Dec 2, 2024
@kartben somehow tihs needs a rebase |
There's no need for the CODEOWNERS file anymore as figuring out maintainership and performing reviewer assignment is done via the MAINTAINERS file now Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
Minor rework to group linters together and to leave the list open in case more linters are added overtime Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
kartben
dismissed stale reviews from keith-zephyr, MaureenHelm, soburi, tejlmand, simhein, and fabiobaltieri
via
December 2, 2024 18:51
f137b83
kartben
force-pushed
the
drop_CODEOWNERS
branch
from
December 2, 2024 18:51
a6227ad
to
f137b83
Compare
kartben
requested review from
keith-zephyr,
tejlmand,
MaureenHelm,
fabiobaltieri,
simhein and
soburi
December 2, 2024 18:51
rebased because Git is picky enough (rightfully so, but still) that git rm'ing a file requires a rebase if the file being deleted has changed |
fabiobaltieri
approved these changes
Dec 2, 2024
keith-zephyr
approved these changes
Dec 2, 2024
soburi
approved these changes
Dec 2, 2024
kartben
changed the title
CODEOWNERS: drop CODEOWNERS file as it's not used anymore
CODEOWNERS: drop CODEOWNERS file as it's not used anymore.
Dec 3, 2024
kartben
changed the title
CODEOWNERS: drop CODEOWNERS file as it's not used anymore.
CODEOWNERS: drop CODEOWNERS file as it's not used anymore
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: Coding Guidelines
Coding guidelines and style
area: Continuous Integration
area: Documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need for the CODEOWNERS file anymore as figuring out
maintainership and performing reviewer assignment is done via the
MAINTAINERS file now.