Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Changes to cortex_m swap code with major impact on kernel context switching times #80702

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Revert Changes to cortex_m swap code with major impact on kernel context switching times #80702

merged 2 commits into from
Nov 1, 2024

Conversation

nashif
Copy link
Member

@nashif nashif commented Oct 31, 2024 •
edited
Loading

  • Revert "arch: arm: cortex_m: restore comment lost in translation"
  • Revert "arch: arm: cortex_m: move part of swap_helper to C"

Fixes #80701

@nashif nashif requested a review from ithinuel October 31, 2024 18:42
@zephyrbot zephyrbot added the area: ARM ARM (32-bit) Architecture label Oct 31, 2024
@nashif nashif requested review from teburd and peter-mitsis and removed request for microbuilder, carlocaione, MaureenHelm, bbolen and galak October 31, 2024 18:42
teburd
teburd approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@teburd teburd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably fixes #79069 by reverting for now, I believe @andyross is trying his hand at an improvement at this as well which will be interesting to see.

Should this be part of the release as its fixing a fairly significant performance regression? Are there any changes in these commits we should be looking closer at @ithinuel to perhaps keep?

Edit: I now see the link to the bug as a release blocker 👍

nashif added 2 commits October 31, 2024 15:06
@nashif
Revert "arch: arm: cortex_m: restore comment lost in translation"
10e0ba8 
This reverts commit 7d76162.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif
Revert "arch: arm: cortex_m: move part of swap_helper to C"
eb5ce9d 
This reverts commit 773739a.

Fixes zephyrproject-rtos#80701

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@mmahadevan108 mmahadevan108 added this to the v4.0.0 milestone Oct 31, 2024
@mmahadevan108 mmahadevan108 added the bug The issue is a bug, or the PR is fixing a bug label Oct 31, 2024
thedjnK
thedjnK approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@thedjnK thedjnK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be backported to 3.7 too

@aescolar aescolar added the backport v3.7-branch Request backport to the v3.7-branch label Oct 31, 2024
@aescolar
Copy link
Member

Should be backported to 3.7 too

I added the label. @nashif if you disagree feel free to remove it

@mmahadevan108 mmahadevan108 merged commit e646b7f into zephyrproject-rtos:main Nov 1, 2024
26 checks passed
@zephyrbot zephyrbot mentioned this pull request Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rruuaanng rruuaanng rruuaanng approved these changes

@peter-mitsis peter-mitsis peter-mitsis approved these changes

@aescolar aescolar aescolar approved these changes

@stephanosio stephanosio stephanosio approved these changes

@dkalowsk dkalowsk dkalowsk approved these changes

@ithinuel ithinuel ithinuel approved these changes

@thedjnK thedjnK thedjnK approved these changes

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@teburd teburd teburd approved these changes

@bbolen bbolen Awaiting requested review from bbolen

@carlocaione carlocaione Awaiting requested review from carlocaione

@galak galak Awaiting requested review from galak

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@microbuilder microbuilder Awaiting requested review from microbuilder

Assignees

@ithinuel ithinuel

Labels
area: ARM ARM (32-bit) Architecture backport v3.7-branch Request backport to the v3.7-branch bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

Changes to cortex_m swap code have major impact on kernel context switching times.