drivers: sensor: lsm6dsv16x: add i3c support #79346
Conversation
dab7847 to
8e7a2f5
Compare
|
@jonas-rem Hey Jonas, can you possibly take a look to this PR? I think you may be in a good position to help us out here. I added you to the reviewers. Thanks very much! |
6bc6b8d to
538579e
Compare
| lsm6dsv16x_reset_set(ctx, LSM6DSV16X_RESTORE_CTRL_REGS); | ||
| do { | ||
| lsm6dsv16x_reset_get(ctx, &rst); | ||
| } while (rst != LSM6DSV16X_READY); |
There was a problem hiding this comment.
Maybe it would be safer to retry a fixed number of times (with delay) and then FAIL if it never returned LSM6DSV16X_READY.
There was a problem hiding this comment.
I found there might be an issue with the reset flow, here and i'll have to revisit this section here anyway to "change stuff"
There was a problem hiding this comment.
You mean in the lsm6dsv16x_reset_set()/lsm6dsv16x_reset_get() APIs themselves? Because in this case I need to debug it as well (I'm the owner of that APIs...). Pls let me know
1c0cbdc to
800ab14
Compare
|
setting to DNM until #80177 is merged in |
1b42358 to
0c622ec
Compare
0c622ec to
f7d6b23
Compare
drivers/i3c/i3c_rtio.c
Outdated
| /* Try for next submission in the transaction */ | ||
| ctx->txn_curr = rtio_txn_next(ctx->txn_curr); | ||
| if (ctx->txn_curr) { | ||
| return true; |
There was a problem hiding this comment.
So in this case the sqe does not get completed neither with 'ok' nor with 'err'. Is this correct?
There was a problem hiding this comment.
lets keep comments about the rtio within #80177
d1622ce to
8271af3
Compare
A typo was made where if the i3c bus is not null, then it will not set the ibi callback. Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
Add I3C support to the lsm6dsv16x. Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
Add a build test for the i3c lsm6dsv16x. Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
8271af3 to
4a98e23
Compare
|
rebasing now that #80177 is merged |
| * 8th byte: EMB_FUNC_STATUS | ||
| * 9th byte: FSM_STATUS | ||
| * 10th byte: MLC_STATUS | ||
| */ |
There was a problem hiding this comment.
Sorry, I'm not able to find this anywhere on the public documentation (AN and datasheet). I could ask here internally to the design team, but I think that in zephyr we should make visible only whatever is public. Am I missing something? Can you point me to the proper doc?
There was a problem hiding this comment.
I checked with design team. It seems that information is currently only internal, maybe shared with some specific customer. Nevertheless, it seems that we may publish it in the future on the AN (not sure why it is not there already...). I'm still investigating about it...
There was a problem hiding this comment.
The general opinion inside ST is that will be documented in the next lsm6dsv16x DS versions, so I'm fine with leaving this part in.
Add I3C support for the lsm6dsv16x, this also includes streaming with i3c ibi