Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zscilib: Add Zephyr PR for Pull Request 62 #78595

Closed
wants to merge 1 commit into from

Conversation

deganii
Copy link

@deganii deganii commented Sep 17, 2024

This diff adds a Zephyr PR for the zscilib PR 62 fixes for quaternions and Madgwick filter

Signed-off-by: Ismail Degani deganii@gmail.com

zscilib: fix computational errors

This diff adds a top-level Zephyr PR for the zscilib quaternion/Madgwick fixes described in detail here:
zephyrproject-rtos/zscilib#62

Signed-off-by: Ismail Degani <deganii@gmail.com>
@zephyrbot zephyrbot added the size: XS A PR changing only a single line of code label Sep 17, 2024
Copy link

Hello @deganii, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@zephyrbot
Copy link
Collaborator

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
zscilib zephyrproject-rtos/zscilib@ee1b287 (master) zephyrproject-rtos/zscilib#62 zephyrproject-rtos/zscilib#62/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-zscilib DNM This PR should not be merged (Do Not Merge) labels Sep 17, 2024
@deganii deganii changed the title Add Zephyr PR for zscilib Pull Request #62 zscilib: Add Zephyr PR for zscilib Pull Request #62 Sep 17, 2024
@deganii deganii changed the title zscilib: Add Zephyr PR for zscilib Pull Request #62 zscilib: Add Zephyr PR for Pull Request #62 Sep 17, 2024
@deganii deganii changed the title zscilib: Add Zephyr PR for Pull Request #62 zscilib: Add Zephyr PR for Pull Request 62 Sep 17, 2024
@kartben
Copy link
Collaborator

kartben commented Oct 15, 2024

@deganii you need to actually amend the commit message, not the PR title.
Also, looks like the CI test failures are legit, could you please have a look? Thanks!

@kartben
Copy link
Collaborator

kartben commented Nov 18, 2024

@deganii ping?

Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Jan 18, 2025
@github-actions github-actions bot closed this Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM This PR should not be merged (Do Not Merge) manifest manifest-zscilib size: XS A PR changing only a single line of code Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants