Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USB: netusb: rndis: Fix always disabled (on MS Windows) #7206

Merged
merged 2 commits into from
Apr 26, 2018
Merged

USB: netusb: rndis: Fix always disabled (on MS Windows) #7206

merged 2 commits into from
Apr 26, 2018

Conversation

finikorg
Copy link
Collaborator

Fixes regression.

finikorg added 2 commits April 26, 2018 10:33
@finikorg
netusb: rndis: Add more debugs
be16163 
Add debug for enable / disable callbacks

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
@finikorg
netusb: rndis: Fix RNDIS always disabled state
7cdc765 
Fix regression with RNDIS due to different USB configuration method.
RNDIS drivers in Windows never call Set Interface and netusb is always
disabled. Change to enable netusb upon USB Set Configuration.

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
@finikorg finikorg requested a review from jukkar April 26, 2018 07:39
@finikorg finikorg requested a review from jfischer-no as a code owner April 26, 2018 07:39
@finikorg
Copy link
Collaborator Author

@loicpoulain

@codecov-io
Copy link

Codecov Report

Merging #7206 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7206   +/-   ##
=======================================
  Coverage   55.03%   55.03%           
=======================================
  Files         477      477           
  Lines       51744    51744           
  Branches     9949     9949           
=======================================
  Hits        28475    28475           
  Misses      19306    19306           
  Partials     3963     3963

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4cb101...7cdc765. Read the comment docs.

jfischer-no
jfischer-no reviewed Apr 26, 2018
View reviewed changes
Copy link
Collaborator

@jfischer-no jfischer-no left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jukkar
jukkar approved these changes Apr 26, 2018
View reviewed changes
Copy link
Member

@jukkar jukkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and the device appears in windows 8, +1 from me.

loicpoulain
loicpoulain requested changes Apr 26, 2018
View reviewed changes
Copy link
Collaborator

@loicpoulain loicpoulain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check there is no regression for ECM and EEM on Linux ?

@finikorg
Copy link
Collaborator Author

@loicpoulain quickly tested ECM and EEM, they are working

@jukkar jukkar merged commit 222aa60 into zephyrproject-rtos:master Apr 26, 2018
@loicpoulain loicpoulain mentioned this pull request May 11, 2018
Closed
@finikorg finikorg deleted the rndis branch September 6, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfischer-no jfischer-no jfischer-no left review comments

@jukkar jukkar jukkar approved these changes

@loicpoulain loicpoulain loicpoulain approved these changes

Assignees
No one assigned
Labels
area: Networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@finikorg @codecov-io @jukkar @jfischer-no @loicpoulain