Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: sphinx: Add Pygment lexer for DTS #6397

Merged
merged 1 commit into from
Mar 23, 2018

Conversation

b0661
Copy link
Collaborator

@b0661 b0661 commented Feb 27, 2018

Add pygment lexer for DTS code-block.

Fixes #6029

Originally developed for #5799.

Signed-off-by: Bobby Noelte b0661n0e17e@gmail.com

Add pygment lexer for DTS code-block.

Fixes zephyrproject-rtos#6029

Origin: skiboot, https://github.com/qemu/skiboot
Status:  91350c5a926795d8917a4eff699941361f780476
Description: Syntax highlighting of Device Tree Source (dts)
Dependencies: None
URL: https://github.com/qemu/skiboot/blob/master/doc/DtsLexer.py
commit: 91350c5a926795d8917a4eff699941361f780476
Maintained-by: External
License: BSL-1.0
License Link:
    https://github.com/qemu/skiboot/blob/master/doc/DtsLexer.py

Signed-off-by: Bobby Noelte <b0661n0e17e@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #6397 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6397   +/-   ##
=======================================
  Coverage   53.08%   53.08%           
=======================================
  Files         430      430           
  Lines       41040    41040           
  Branches     7908     7908           
=======================================
  Hits        21785    21785           
  Misses      16032    16032           
  Partials     3223     3223

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 571069e...4121016. Read the comment docs.

Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I don't object to adding DTS support, @nashif hasn't been keen on pre-empting delayed upstream patches by adding them to the Zephyr project directly. Looks like this code came from here: https://patchwork.ozlabs.org/patch/688187/. Will we need to add this BSD licensed (?) item to our licensing list? I'll defer to Anas for his approval.

@b0661
Copy link
Collaborator Author

b0661 commented Feb 27, 2018

The reference is to skiboot where this patch stems from (and is applied). For delayed upstream one would have to look at pygments. I haven´t found the pull request there https://bitbucket.org/birkenfeld/pygments-main/pull-request.

@dbkinder
Copy link
Contributor

thanks for clarifying this hasn't been submitted upstream to pygments.

@b0661
Copy link
Collaborator Author

b0661 commented Mar 23, 2018

@nashif is there anything open that prevents a merge?

Thx Bobby

@nashif nashif merged commit a5a29e4 into zephyrproject-rtos:master Mar 23, 2018
@b0661 b0661 deleted the pr_pinctrl_doc_sphinx branch October 16, 2018 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants