samples: sockets: http_get: More configurability and logging #5981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to use this sample as a guinea ping for #5900 , makes sense to clean it up first. |
Codecov Report
@@ Coverage Diff @@
## master #5981 +/- ##
=======================================
Coverage 52.51% 52.51%
=======================================
Files 406 406
Lines 39682 39682
Branches 7715 7715
=======================================
Hits 20838 20838
Misses 15663 15663
Partials 3181 3181Continue to review full report at Codecov.
|
828866c to
8398756
Compare
Make it easy to override HTTP host/port/path. Print URL which we request and make few other adjustment to the output for clarity. Signed-off-by: Paul Sokolovsky <paul.sokolovsky@linaro.org>
8398756 to
19d9231
Compare
19d9231 to
c09bd7a
Compare
8 tasks
jukkar
approved these changes
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it easy to override HTTP host/port/path. Print URL which we
request and make few other adjustment to the output for clarity.
Signed-off-by: Paul Sokolovsky paul.sokolovsky@linaro.org