Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: net: echo_client: Only send allowable number of bytes #5072

Merged
merged 1 commit into from
Nov 20, 2017

Conversation

jukkar
Copy link
Member

@jukkar jukkar commented Nov 20, 2017

Honor the device MTU when sending data.

Signed-off-by: Jukka Rissanen jukka.rissanen@linux.intel.com

Honor the device MTU when sending data.

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Copy link
Member

@dleach02 dleach02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine although I'm guessing now the complexity of breaking up a large transmit has now been moved to the application layer if net_pkt_append() doesn't fit everything in?

@jukkar
Copy link
Member Author

jukkar commented Nov 20, 2017

This looks fine although I'm guessing now the complexity of breaking up a large transmit has now been moved to the application layer if net_pkt_append() doesn't fit everything in?

Yes, that is the case. It is quite difficult to buffer the data inside the IP stack, which means that we need to push this logic upper in the stack.

@nashif nashif merged commit 9d99691 into zephyrproject-rtos:master Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants