drivers: entropy: stm32: Add power management constraints #42375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwango
requested changes
Feb 1, 2022
gmarull
requested changes
Feb 1, 2022
erwango
requested changes
Feb 2, 2022
555baf9 to
e1c6576
Compare
erwango
reviewed
Feb 2, 2022
e1c6576 to
1bf90f3
Compare
gmarull
previously approved these changes
Feb 2, 2022
Well, I think you might be right. with reverting the flag, I think the pm_constraint_set can indeed be set multiple times now before releasing. Let me check further/fix that |
Add power management constraints to the entropy driver. This prevents the hardware block to lose it's clock when going into any stop mode of the cpu, which would cause the clock error flag to be set while filling the pool. Signed-off-by: Wouter Cappelle <wouter.cappelle@crodeon.com>
1bf90f3 to
52c2c39
Compare
|
@gmarull , i've fixed the possible double set. |
|
@erwango , I've added the comment. Do you have and further review comments? |
erwango
approved these changes
Feb 2, 2022
ceolin
approved these changes
Feb 10, 2022
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add power managment constraints to the entropy driver.
This prevents the hardware block to lose it's clock when going into any stop mode of the cpu, which would cause the clock error flag to be set while filling the pool.
This is a part of #42374