drivers: sensor: Add support for grow_r502a fingerprint sensor #40394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e718cf8 to
833a24f
Compare
tejlmand
reviewed
Nov 17, 2021
833a24f to
ac2e3e8
Compare
ac2e3e8 to
f9ed1a3
Compare
mbolivar-nordic
previously requested changes
Dec 3, 2021
f9ed1a3 to
eef0c49
Compare
eef0c49 to
24cc8c3
Compare
b691a31 to
591323d
Compare
gmarull
requested changes
Dec 23, 2021
591323d to
c6bc8ba
Compare
045703f to
2297607
Compare
2297607 to
72758b3
Compare
|
@mbolivar-nordic @MaureenHelm @gmarull kindly revisit. |
MaureenHelm
requested changes
Nov 29, 2022
we have hzgrow,r502a binding. Signed-off-by: Dinesh Kumar K <dinesh@linumiz.com>
Add driver support for grow_r502a fingerprint sensor Signed-off-by: Dinesh Kumar K <dinesh@linumiz.com>
Added sample application for grow_r502a fingerprint sensor Signed-off-by: Dinesh Kumar K <dinesh@linumiz.com>
Included GROW_R502A fingerprint sensor in the build_all test to test grow_r502a driver Signed-off-by: Dinesh Kumar K <dinesh@linumiz.com>
72758b3 to
c816cb6
Compare
MaureenHelm
reviewed
Nov 30, 2022
Comment on lines
+21
to
+23
| #address-cells=<1>; | ||
| #size-cells=<0>; | ||
| grow_r502a@0 { |
There was a problem hiding this comment.
Why does this have an address?
There was a problem hiding this comment.
basically, this fingerprint sensor creates an RX packet based on the address we are going to pass, initially, it was passed to the driver via the address parameter from the fps node and then based on the PR suggestion from @gmarull here address is given to driver via reg property. if you are having any conflict of opinion please let me know. thanks
MaureenHelm
approved these changes
Dec 6, 2022
ssekar15
approved these changes
Dec 7, 2022
|
@mbolivar-nordic @galak @gmarull Ping, kindly re-visit the PR |
no longer reviewing bindings etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added driver and other support needed for r502a fingerprint sensor
Signed-off-by: Dinesh Kumar K dinesh@linumiz.com