drivers: sensor: Add driver for TI INA23x #35753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carlescufi, @sambhurst I'm on vacation for about 2 weeks, but I'm happy to review this PR afterwards. |
galak
requested changes
Jun 11, 2021
galak
previously requested changes
Jun 11, 2021
gmarull
requested changes
Jun 14, 2021
gmarull
reviewed
Jun 18, 2021
gmarull
reviewed
Jun 18, 2021
f05c700 to
b21fa83
Compare
gmarull
reviewed
Jun 19, 2021
|
@galak when you have time, could you take another look at this pull request? Thanks |
9d111f8 to
c579784
Compare
martinjaeger
approved these changes
Jun 27, 2021
|
@galak I've made the changes you've requested.
Are there any further changes you think I need to make? Thank you |
mbolivar-nordic
suggested changes
Jun 29, 2021
|
I've made the changes you've requested. Are there any further changes you think I need to make? Thank you |
mbolivar-nordic
approved these changes
Jul 15, 2021
Moving the BIT macros from <sys/util.h> to <sys/util_macro.h> allows the BIT macros to be used in device trees. Testing: twister -T tests/drivers/build_all/sensor/ Signed-off-by: Sam Hurst <sbh1187@gmail.com>
This driver supports the TI INA230 and INA231 Bidirectional Current and Power Monitors. The devices work on the I2C interface and are created from DT nodes with a compatible property matching "ti,ina23x". The following datasheets were referenced while developing the driver: https://www.ti.com/product/INA230 https://www.ti.com/product/INA231 Twister passed: twister -T tests/drivers/build_all/sensor/ Testing was performed on the stm32g071b_disco board with the following: Load: ~170 ohms Voltage: 5V Measured Values: Voltage: 5.1 V Current: 0.032 A Power: 0.157 W Signed-off-by: Sam Hurst <sbh1187@gmail.com>
cfriedt
reviewed
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This driver supports the TI INA230 and INA231 Bidirectional Current
and Power Monitors. The devices work on the I2C interface and are
created from DT nodes with a compatible property matching "ti,ina23x".
The following datasheets were referenced while developing the driver:
https://www.ti.com/product/INA230
https://www.ti.com/product/INA231
Testing was performed on the stm32g071b_disco board:
twister --west-flash --device-testing --device-serial /dev/ttyACM0
-p stm32g071b_disco -T samples/sensor/ina23x
Signed-off-by: Sam Hurst sbh1187@gmail.com