Bluetooth: controller: Add conn creation param checks #35527
Conversation
| conn_latency, | ||
| supervision_timeout); | ||
| if (status) { | ||
| goto exit; |
There was a problem hiding this comment.
Align with the other early returns in error handling. Confusing to combine two patterns for this.
| goto exit; | |
| *evt = cmd_status(status); | |
| return; |
(or goto exit in both places)
| conn_latency, | ||
| supervision_timeout); | ||
| if (status) { | ||
| goto exit; |
| * sto * 10 > (1 + lat) * ci * 2.5 | ||
| * sto * 2 > (1 + lat) * ci * 0.5 | ||
| */ | ||
| if ((supervision_timeout << 1) < (1 + conn_latency) * (conn_interval_max >> 1)) { |
There was a problem hiding this comment.
Doesn't this introduce a rounding error on conn. interval?
Say: STO=10, LAT=5 and CI=7
100 > 6 * 7 * 2.5 = 105
vs
20 > 6 * 3 = 18
There was a problem hiding this comment.
Instead of re-inventing, maybe just re-use the host expression?
((supervision_timeout * 4U) <= ((1U + conn_latency) * conn_interval_max))
There was a problem hiding this comment.
Sure, I can add a partial fix for that
There was a problem hiding this comment.
@thoh-ot I've added a compensation for the rounding error.
There was a problem hiding this comment.
Instead of re-inventing, maybe just re-use the host expression?
I missed this comment, sure that makes sense. Thanks @joerchan
There was a problem hiding this comment.
Done now, thanks both!
1596497 to
e272f1e
Compare
Coverity detected that a zero divisor can be passed to ll_create_connection() without parameter sanitization. Conditionally check the connection creation parameters according to spec. Fixes zephyrproject-rtos#35343. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
Coverity detected that a zero divisor can be passed to
ll_create_connection() without parameter sanitization. Conditionally
check the connection creation parameters according to spec.
Fixes #35343.
Signed-off-by: Carles Cufi carles.cufi@nordicsemi.no