drivers: console: uart_mux: fix build issues #35491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With logging enabled, building of uart_mux.c fails with an error message indicating that struct gsm_dlci is undefined. In fact, struct gsm_dlci is declared in gsm_mux.h, but defined in gsm_mux.c. The build error is caused by calls to LOG_DBG, which displays a pointer to struct gsm_dlci as a generic pointer. The error is resolved by typecasts to (void *). Fixes zephyrproject-rtos#35489 Signed-off-by: Hans Wilmers <hans@wilmers.no>
|
Closing, since this is already fixed in pr35330 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With logging enabled, building of uart_mux.c fails with an error
message indicating that struct gsm_dlci is undefined. In fact,
struct gsm_dlci is declared in gsm_mux.h, but defined in gsm_mux.c.
The build error is caused by calls to LOG_DBG, which displays a
pointer to struct gsm_dlci as a generic pointer.
The error is resolved by typecasts to (void *).
Fixes #35489
Signed-off-by: Hans Wilmers hans@wilmers.no