Bluetooth: controller: Various coverity related fixes #35426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix side effect in assertion when checking a volatile variable inside assert check. Fixes zephyrproject-rtos#32904, zephyrproject-rtos#32923. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Explicitly ignore return value from call to mayfly_enqueue. Fixes zephyrproject-rtos#32917, zephyrproject-rtos#32961. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Add assert check to avoid deferencing null return value by ull_adv_set_get() function. Fixes zephyrproject-rtos#35347. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
carlescufi
approved these changes
May 19, 2021
wopu-ot
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix side effect in assertion when checking a volatile
variable inside assert check.
Fixes #32904.
Fixes #32923.
Explicitly ignore return value from call to mayfly_enqueue.
Fixes #32917.
Fixes #32961.
Add assert check to avoid deferencing null return value by
ull_adv_set_get() function.
Fixes #35347.
Signed-off-by: Vinayak Kariappa Chettimada vich@nordicsemi.no