Minor fixes on labels for GPIO and PWM LEDs #35300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the label property is missing in a "pwm-leds" compatible DT node (which is almost always the case), then the device name is now set to DT_NODE_FULL_NAME instead of "LED_PWM_$inst" previously. This allows applications to use the DEVICE_DT_NAME macro to retrieve the device name instead of gessing an arbitrary string. Signed-off-by: Simon Guinot <simon.guinot@seagate.com>
This patch adds a label property to the PWM LED parent node and fixes the label property description of the child node. Indeed it is the label of a parent node which can be used as device_get_binding() parameter to retrieve the LED device, and not the one of a child node. Fixes zephyrproject-rtos#34275 Signed-off-by: Simon Guinot <simon.guinot@seagate.com>
This patch adds a label property to the GPIO LED parent node and fixes the label property description of the child node. Indeed it is the label of a parent node which can be used as device_get_binding() parameter to retrieve the LED device, and not the one of a child node. In addition, this patch sets both this properties as not required because they are not. Signed-off-by: Simon Guinot <simon.guinot@seagate.com>
22b1568 to
4f6abd2
Compare
|
@Mani-Sadhasivam I'm not sure why you cleared your assignment since this is an LED PR. Please review. |
Mani-Sadhasivam
approved these changes
May 19, 2021
Ah, sorry. I got confused with the PR subject (thought it is the GPIO). Approved now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first patch fixes/improves the name of a PWM LED device when the label property is missing in its DT node.
And the last two patches fix some minor issues about label properties in the DTS bindings of both GPIO and PWM LEDs (#34275).