Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cpp exception #34357

Closed
wants to merge 2 commits into from
Closed

Cpp exception #34357

wants to merge 2 commits into from

Conversation

galak
Copy link
Collaborator

@galak galak commented Apr 16, 2021 •
edited
Loading

  • Figure out how to link crtbegin.o and crtend.o cleanly
  • Fixup linker scripts for .ehframe and such

@galak galak requested a review from tejlmand April 16, 2021 21:30
@github-actions github-actions bot added area: API Changes to public APIs area: C Library C Standard Library area: RISCv32/64 area: Samples Samples area: Tests Issues related to a particular existing or missing test area: X86 x86 Architecture (32-bit) labels Apr 16, 2021
@galak galak mentioned this pull request Apr 16, 2021
Closed
mbolivar-nordic
mbolivar-nordic reviewed May 25, 2021
View reviewed changes
CMakeLists.txt
@@ -1026,7 +1026,7 @@ if(CONFIG_USERSPACE)
)

set(APP_SMEM_UNALIGNED_LIB app_smem_unaligned_output_obj_renamed_lib)
add_executable( app_smem_unaligned_prebuilt misc/empty_file.c)
add_executable( app_smem_unaligned_prebuilt ${LIBGCC_DIR}/crtbeing.o misc/empty_file.c)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@tejlmand tejlmand mentioned this pull request May 25, 2021
Merged
@galak galak closed this May 25, 2021
@galak galak deleted the cpp-exception branch May 25, 2021 21:48
@katsuster katsuster added area: RISCV RISCV Architecture (32-bit & 64-bit) and removed area: RISCv32/64 labels Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbolivar-nordic mbolivar-nordic mbolivar-nordic left review comments

@tejlmand tejlmand Awaiting requested review from tejlmand

Assignees
No one assigned
Labels
area: API Changes to public APIs area: C Library C Standard Library area: RISCV RISCV Architecture (32-bit & 64-bit) area: Samples Samples area: Tests Issues related to a particular existing or missing test area: X86 x86 Architecture (32-bit)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galak @mbolivar-nordic @katsuster