Bluetooth: shell: Fix null check in cmd_conn_phy_update

[kaiser-ren]

When I used ./tests/bluetooth/shell, if there is not any connections established but perform bt phy-update, it can cause a fatal error because of conn-check-missing, null check for default_conn pointer is necessary in case causing a system failure.

Fixes #34201

[kaiser-ren]

Try to fix #34201

[cvinayak]

Other commands like data length update, connection update, etc... all have this issue. Its best to address them all.

[Thalley]

I generally agree with @cvinayak regarding adding this everywhere, but I'm perfectly content to fix those in other PRs.

[joerchan]

The merge commits must be removed.

[Thalley]

@kaiser-ren Btw, you can link this PR to the issue by using one of the Github closing keywords in the pull request description: https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

That way, when this is merged, the issue is automatically marked as done.

[kaiser-ren]

@kaiser-ren Btw, you can link this PR to the issue by using one of the Github closing keywords in the pull request description: https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

That way, when this is merged, the issue is automatically marked as done.

Thanks. Apologize that this is my first zephyr pull request, it may take some time.

[kaiser-ren]

Here is a CI error, Commit e8d025fca8:
3: UC4 Line exceeds max length (109>72): "For Link Layer PHY update, null check for default_conn pointer is necessary in case causing a system failure."
I'm not sure how can I modify the commit message? And it's already being public on Zephyr repo.

[Thalley]

Here is a CI error, Commit e8d025fca8: 3: UC4 Line exceeds max length (109>72): "For Link Layer PHY update, null check for default_conn pointer is necessary in case causing a system failure."
I'm not sure how can I modify the commit message? And it's already being public on Zephyr repo.

You can modify your commit message but doing either git commit --amend or using git rebase -i

[joerchan]

@kaiser-ren You should read up on the contributing guidelines for the project, that will help you get this PR ready.
https://docs.zephyrproject.org/latest/contribute/index.html#contribution-workflow

[kaiser-ren]

Here is a CI error, Commit e8d025fca8: 3: UC4 Line exceeds max length (109>72): "For Link Layer PHY update, null check for default_conn pointer is necessary in case causing a system failure."
I'm not sure how can I modify the commit message? And it's already being public on Zephyr repo.

You can modify your commit message but doing either git commit --amend or using git rebase -i

Thanks, fixed.

[Thalley]

Please also reduce the commits to just one commit.

[joerchan]

@kaiser-ren The commit is empty.

[kaiser-ren]

Apologize very deeply to make this PR mess, finally, make CI happy except buildkite is still ongoing. @Thalley, already merged the commit into one.
This 1st PR makes me learn a lot, thanks for your guide and patient.

[Thalley]

Looks alright to me

[Thalley]

Indentation seems slight off, but not something I would block this PR for

[nordic-krch]

\n is redundant. shell_error adds in.

[kaiser-ren]

Thanks @nordic-krch .
@nordic-krch and @Thalley , after this PR, I will create another PR to add the null check for conn_update() and conn_data_length_update(), how about I fix "\n" at the next PR and we keep this approval process going? Sound good to every approver?

[nordic-krch]

i think that you can remove \n in this PR, if there is no critical changes others reviewers don't need to re-review and approvals stays.

[Thalley]

I agree with @nordic-krch

[kaiser-ren]

Roger, I've already done it.