Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: Fix STM32F103XE not able to enter master mode #33900

Closed
wants to merge 3 commits into from
Closed

drivers: Fix STM32F103XE not able to enter master mode #33900

wants to merge 3 commits into from

Conversation

ycsin
Copy link
Member

@ycsin ycsin commented Mar 31, 2021 •
edited
Loading

This pr fixes the I2C issue mentioned in #33196

Signed-off-by: Yong Cong Sin yongcong@gtsb.com.my

@ycsin ycsin requested a review from ydamigos as a code owner March 31, 2021 02:08
@ycsin ycsin changed the title Fix STM32F103XE not able to enter master mode drivers: Fix STM32F103XE not able to enter master mode Mar 31, 2021
@ycsin
Copy link
Member Author

ycsin commented Mar 31, 2021

ping @erwango

@erwango erwango requested a review from FRASTM March 31, 2021 07:02
erwango
erwango requested changes Mar 31, 2021
View reviewed changes
@ycsin @erwango
Reduce line length
8c77cdb 
Co-authored-by: Erwan Gouriou <erwan.gouriou@linaro.org>
@tagunil
Copy link
Collaborator

tagunil commented Mar 31, 2021

Shouldn't this fix be extended to handle all STM32F1 devices by using CONFIG_SOC_SERIES_STM32F1X?

@erwango
Copy link
Member

erwango commented Mar 31, 2021

Shouldn't this fix be extended to handle all STM32F1 devices by using CONFIG_SOC_SERIES_STM32F1X?

@tagunil This is correct, I've just checked and this behavior is present in all STM32F1 series. Thanks

@ycsin Can you use CONFIG_SOC_SERIES_STM32F1X instead of the initial #ifdef combination ?

@ycsin
Copy link
Member Author

ycsin commented Apr 1, 2021

Shouldn't this fix be extended to handle all STM32F1 devices by using CONFIG_SOC_SERIES_STM32F1X?

@tagunil This is correct, I've just checked and this behavior is present in all STM32F1 series. Thanks

@ycsin Can you use CONFIG_SOC_SERIES_STM32F1X instead of the initial #ifdef combination ?

Done

erwango
erwango requested changes Apr 1, 2021
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself is correct, but please squash your commits into one.
Also please pay attention to the signed-off-by (as reported by compliance checks)

@ycsin ycsin mentioned this pull request Apr 7, 2021
Closed
@ycsin
Copy link
Member Author

ycsin commented Apr 7, 2021

closed: #34088

@ycsin ycsin closed this Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwango erwango erwango requested changes

@FRASTM FRASTM FRASTM approved these changes

@ydamigos ydamigos Awaiting requested review from ydamigos

Assignees

@erwango erwango

Labels
area: I2C platform: STM32 ST Micro STM32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ycsin @tagunil @erwango @FRASTM