Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix collection of coverity errors #33899

Merged
merged 5 commits into from
Apr 1, 2021
Merged

Fix collection of coverity errors #33899

merged 5 commits into from
Apr 1, 2021

Conversation

dleach02
Copy link
Member

Fix a collection of low hanging coverity errors

Fixes #33809
Fixes #33060
Fixes #33791
Fixes #33818
Fixes #33792
Fixes #33789
Fixes #33796
Fixes #33797
Fixes #33793
Fixes #33811
Fixes #33816

Signed-off-by: David Leach david.leach@nxp.com

@dleach02
tests: posix: Fix unchecked return coverity error
5b7f8ca 
New test cases did not check return value of pthread_attr_init()

Fixes #33809

Signed-off-by: David Leach <david.leach@nxp.com>
@github-actions github-actions bot added area: Logging area: Tests Issues related to a particular existing or missing test labels Mar 31, 2021
dleach02 added 4 commits March 30, 2021 20:34
@dleach02
subsys/cmsis_v1: Fix unitialized struct coverity error
28d4988 
Fixes #33060

Signed-off-by: David Leach <david.leach@nxp.com>
@dleach02
logging: log_backend_fs: Fix check for error on fs_sync() - coverity
ea1b54c 
Fixes #33791

Signed-off-by: David Leach <david.leach@nxp.com>
@dleach02
subsys/modbus: Fix potential memory overwrite (coverity)
d947eef 
The size of ctx->rx_adu.data is not CONFIG_MODBUS_BUFFER_SIZE. Coverity
flagged the potential overwrite so just use sizeof().

Fixes #33789
Fixes #33792
Fixes #33818

Signed-off-by: David Leach <david.leach@nxp.com>
@dleach02
tests: modbus: Fix potential memory overwrite (coverity)
829cd3d 
Fixes #33816
Fixes #33811
Fixes #33793
Fixes #33797
Fixes #33796

Signed-off-by: David Leach <david.leach@nxp.com>
@dleach02 dleach02 requested a review from MaureenHelm March 31, 2021 01:38
@zephyrbot zephyrbot added area: POSIX POSIX API Library area: Portability Standard compliant code, toolchain abstraction labels Mar 31, 2021
@zephyrbot zephyrbot requested review from chen-png and enjiamai March 31, 2021 02:00
@nashif nashif merged commit 8272b32 into zephyrproject-rtos:master Apr 1, 2021
@dleach02 dleach02 deleted the fix_33809 branch April 1, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaureenHelm MaureenHelm MaureenHelm approved these changes

@jfischer-no jfischer-no jfischer-no approved these changes

@galak galak galak approved these changes

@KangJianX KangJianX KangJianX approved these changes

@nashif nashif Awaiting requested review from nashif

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

@pfalcon pfalcon Awaiting requested review from pfalcon

@chen-png chen-png Awaiting requested review from chen-png

@enjiamai enjiamai Awaiting requested review from enjiamai

Assignees

@nordic-krch nordic-krch

Labels
area: Logging area: Portability Standard compliant code, toolchain abstraction area: POSIX POSIX API Library area: Tests Issues related to a particular existing or missing test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Coverity CID: 220443] Out-of-bounds access in tests/subsys/modbus/src/test_modbus_raw.c [Coverity CID: 220444] Out-of-bounds access in subsys/modbus/modbus_raw.c [Coverity CID: 220445] Unchecked return value in subsys/logging/log_backend_fs.c [Coverity CID: 220447] Out-of-bounds access in subsys/modbus/modbus_raw.c [Coverity CID :219613] Uninitialized scalar variable in lib/cmsis_rtos_v1/cmsis_signal.c
[Coverity CID: 220440] Out-of-bounds access in tests/subsys/modbus/src/test_modbus_raw.c [Coverity CID: 220439] Destination buffer too small in tests/subsys/modbus/src/test_modbus_raw.c [Coverity CID: 220427] Unchecked return value in tests/posix/common/src/pthread.c [Coverity CID: 220425] Destination buffer too small in tests/subsys/modbus/src/test_modbus_raw.c [Coverity CID: 220420] Out-of-bounds access in tests/subsys/modbus/src/test_modbus_raw.c
8 participants
@dleach02 @MaureenHelm @jfischer-no @galak @KangJianX @nashif @nordic-krch @zephyrbot