-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reel board custom config pyocd #33386
Reel board custom config pyocd #33386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I didn't know about the pycod --config option.
@flit fyi
Looks good. One consideration is that pyocd currently only supports one config file (multiple are on the todo list), so having a board-specific config file will preclude a user/project config file. |
|
||
# Use HW reset option on reel_board | ||
reset_type: 'hw' | ||
# Hold HW reset asserted for 0.5s. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment needs update (todo)
Is this something we could fix on the runner code? E.g. add logic so if both config files exist, pick the one that has precedence? |
If this is something you're concerned about, it might be better to just implement multiple config file support in pyocd. (Of course I would say that! 😉) The hardest part would be handling For now, this PR is probably fine as is. If needed, the user can use |
1bb329f
to
ead31d9
Compare
Add support for including a board-specific config.yaml file in the pyocd flash command. Similary to openOCD, the config file is placed in the board directory under support/. Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
Add a pyocd.yaml for reel_board, to pass board-specific pyocd configuration. Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
ead31d9
to
fef8de4
Compare
Fixes #32966 (the fix is for the reel_board).
The PR