Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reel board custom config pyocd #33386

Merged

Conversation

ioannisg
Copy link
Member

Fixes #32966 (the fix is for the reel_board).
The PR

  • adds support in pyocd runner to attach a board-specific configuration file
  • use a board-specific pyocd.yaml file for reel_board, to pass configuration for the flash command

Copy link
Member

@MaureenHelm MaureenHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I didn't know about the pycod --config option.

@flit fyi

@flit
Copy link
Contributor

flit commented Mar 16, 2021

Looks good.

One consideration is that pyocd currently only supports one config file (multiple are on the todo list), so having a board-specific config file will preclude a user/project config file.

@ioannisg ioannisg added the block: HW Test Testing on hardware required before merging label Mar 16, 2021

# Use HW reset option on reel_board
reset_type: 'hw'
# Hold HW reset asserted for 0.5s.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment needs update (todo)

@ioannisg
Copy link
Member Author

Looks good.

One consideration is that pyocd currently only supports one config file (multiple are on the todo list), so having a board-specific config file will preclude a user/project config file.

Is this something we could fix on the runner code? E.g. add logic so if both config files exist, pick the one that has precedence?

@flit
Copy link
Contributor

flit commented Mar 16, 2021

If this is something you're concerned about, it might be better to just implement multiple config file support in pyocd. (Of course I would say that! 😉) The hardest part would be handling --no-config mixed into the command line.

For now, this PR is probably fine as is. If needed, the user can use --tool-opt="--config=<path>" to override the config file path.

@ioannisg ioannisg force-pushed the reel_board_custom_config_pyocd branch from 1bb329f to ead31d9 Compare March 16, 2021 16:21
Add support for including a board-specific config.yaml file
in the pyocd flash command. Similary to openOCD, the config
file is placed in the board directory under support/.

Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
Add a pyocd.yaml for reel_board, to pass board-specific
pyocd configuration.

Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
@ioannisg ioannisg force-pushed the reel_board_custom_config_pyocd branch from ead31d9 to fef8de4 Compare March 16, 2021 17:13
@nashif nashif merged commit 35f0ed2 into zephyrproject-rtos:master Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Boards area: West West utility block: HW Test Testing on hardware required before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

frdm_k64f: Run some testcases timeout failed by using twister
6 participants