-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arch/arm: cortex_m: Disable DWT null-pointer exception detection #33126
Merged
nashif
merged 2 commits into
zephyrproject-rtos:master
from
erwango:temp_disable_null_pointer_exception_detection
Mar 9, 2021
Merged
arch/arm: cortex_m: Disable DWT null-pointer exception detection #33126
nashif
merged 2 commits into
zephyrproject-rtos:master
from
erwango:temp_disable_null_pointer_exception_detection
Mar 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad271b2
to
70e56dd
Compare
Null-pointer exception detection using DWT is currently incompatible with current openocd runner default implementation that leaves debug mode on by default. As a consequence, on all targets that use openocd runner, null-pointer exception detection using DWT will generated an assert. As a consequence, all tests are failing on such platforms. Disable this until openocd behavior is fixed (zephyrproject-rtos#32984) and enable the MPU based solution for now. Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
70e56dd
to
99047a1
Compare
galak
approved these changes
Mar 8, 2021
ioannisg
reviewed
Mar 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is as good as it can get right now, @erwango thanks for the leaving the MPU-solution enabled; I guess this has nothing to do with openOCD.
Default null pointer exception detection to the DWT solution instead of MPU based solution. Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
5276ce4
to
49343ad
Compare
nashif
approved these changes
Mar 9, 2021
this fixes this issue for me #32966 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Null-pointer exception detection using DWT is currently incompatible
with current openocd runner default implementation that leaves debug
mode on by default.
As a consequence, on all targets that use openocd runner, null-pointer
exception detection using DWT will generated an assert.
As a consequence, all tests are failing on such platforms.
Disable this until openocd behavior is fixed (#32984)
Rationale: #31481 is a great addition, but given this is making a wide range of boards unusable, I think it's activation can wait #32984 to be fixed.
Signed-off-by: Erwan Gouriou erwan.gouriou@linaro.org
EDIT: Following discussion with @ioannisg and @galak, enable DWT based solution on Nordic based platforms