stm32: coverity fixes (gpio and watchdog) #33124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2e6999 to
74a0e10
Compare
gmarull
requested changes
Mar 8, 2021
74a0e10 to
99dc74c
Compare
In function gpio_stm32_enable_int, retiurn value of clock_control_on was not checked. This is reported as an issue by coverity (CID 219652). Fix this. Fixes zephyrproject-rtos#33035 Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
99dc74c to
5224332
Compare
gmarull
reviewed
Mar 8, 2021
drivers/watchdog/wdt_wwdg_stm32.c
Outdated
|
|
||
| wwdg_stm32_irq_config(dev); | ||
|
|
||
| return 0; | ||
| ret = clock_control_on(clk, (clock_control_subsys_t *) &cfg->pclken); |
There was a problem hiding this comment.
Nitpick: you may return directly here
5224332 to
72c2fc1
Compare
gmarull
reviewed
Mar 8, 2021
drivers/watchdog/wdt_wwdg_stm32.c
Outdated
| @@ -250,12 +250,11 @@ static int wwdg_stm32_init(const struct device *dev) | |||
| { | |||
| const struct device *clk = DEVICE_DT_GET(STM32_CLOCK_CONTROL_NODE); | |||
| const struct wwdg_stm32_config *cfg = WWDG_STM32_CFG(dev); | |||
|
|
|||
| clock_control_on(clk, (clock_control_subsys_t *) &cfg->pclken); | |||
| int ret; | |||
In function wwdg_stm32_init, return value of clock_control_on was not checked. This is reported as an issue by coverity (CID 219600). Fix this. Fixes zephyrproject-rtos#33067 Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
72c2fc1 to
a6cffea
Compare
gmarull
approved these changes
Mar 8, 2021
FRASTM
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: [Coverity CID :219652] Unchecked return value in drivers/gpio/gpio_stm32.c #33035
Fixes: [Coverity CID :219600] Unchecked return value in drivers/watchdog/wdt_wwdg_stm32.c #33067