Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: bluetooth: Fix SRAM overflow with bbc:microbit #32562

Merged
merged 1 commit into from
Feb 24, 2021
Merged

samples: bluetooth: Fix SRAM overflow with bbc:microbit #32562

merged 1 commit into from
Feb 24, 2021

Conversation

LingaoM
Copy link
Collaborator

@LingaoM LingaoM commented Feb 23, 2021

arm-zephyr-eabi/bin/ld: region SRAM' overflowed by 19 bytes`

Signed-off-by: Lingao Meng menglingao@xiaomi.com

@LingaoM LingaoM added bug The issue is a bug, or the PR is fixing a bug area: Samples Samples area: Bluetooth Mesh labels Feb 23, 2021
@trond-snekvik
Copy link
Contributor

A bit surprised that this hasn't been caught by CI. What compiler version are you using?

@LingaoM
Copy link
Collaborator Author

LingaoM commented Feb 23, 2021

A bit surprised that this hasn't been caught by CI. What compiler version are you using?

zephyr-sdk-0.11.4

jhedberg
jhedberg approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@jhedberg jhedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but could you rephrase the commit message to say "RAM overflow" instead of "buffer overflow" to make it clear what the issue is.

@LingaoM
samples: bluetooth: Fix SRAM overflow with bbc:microbit
5192258 
`arm-zephyr-eabi/bin/ld: region `SRAM' overflowed by 19 bytes`

Signed-off-by: Lingao Meng <menglingao@xiaomi.com>
@LingaoM LingaoM force-pushed the add_support_new_board branch from 2e0b8f6 to 5192258 Compare February 24, 2021 03:55
@LingaoM
Copy link
Collaborator Author

LingaoM commented Feb 24, 2021

Looks fine, but could you rephrase the commit message to say "RAM overflow" instead of "buffer overflow" to make it clear what the issue is.

Done.

@LingaoM LingaoM changed the title samples: bluetooth: Fix buffer overflow with bbc:microbit samples: bluetooth: Fix SRAM overflow with bbc:microbit Feb 24, 2021
@jhedberg jhedberg mentioned this pull request Feb 24, 2021
Closed
@carlescufi carlescufi added the Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc. label Feb 24, 2021
@carlescufi carlescufi merged commit db2f871 into zephyrproject-rtos:master Feb 24, 2021
@jhedberg jhedberg mentioned this pull request Feb 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhedberg jhedberg jhedberg approved these changes

@joerchan joerchan joerchan approved these changes

@trond-snekvik trond-snekvik trond-snekvik approved these changes

@carlescufi carlescufi carlescufi approved these changes

@Vudentz Vudentz Awaiting requested review from Vudentz

Assignees

@jhedberg jhedberg

Labels
area: Bluetooth Mesh area: Bluetooth area: Samples Samples bug The issue is a bug, or the PR is fixing a bug Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LingaoM @trond-snekvik @jhedberg @joerchan @carlescufi @zephyrbot