drivers: counter: stm32: fix alarm time calculation #32262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbe745d to
9f1328d
Compare
The calculated alarm time starts from 2000 but the gmtime_r needs as input the time from epoch (1970). This causes the alarm time to be miscalculated due to leap years, as 2000 is a leap year and 1970 is not. To fix the issue, the 2000 timestamp can be added to the input time of gmtime_r. Fixes zephyrproject-rtos#32260 Signed-off-by: Antonis Sioutas <antonis.si510@gmail.com>
9f1328d to
8d3775a
Compare
erwango
approved these changes
Feb 12, 2021
FRASTM
approved these changes
Feb 12, 2021
nashif
approved these changes
Feb 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calculated alarm time starts from 2000 but the gmtime_r needs as
input the time from epoch (1970). This causes the alarm time to be
miscalculated due to leap years, as 2000 is a leap year and 1970 is not.
To fix the issue, the 2000 timestamp can be added to the input time of
gmtime_r.
Fixes #32260
Signed-off-by: Antonis Sioutas antonis.si510@gmail.com