net: ip_k66f: Rework of network stack to support raw sockets when CONFIG_NET_{UDP|TCP} enabled #30934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d41c93 to
42ef386
Compare
jukkar
reviewed
Dec 21, 2020
There was a problem hiding this comment.
Looks okeyish, we are missing tests to check the functionality. Could you add test(s) to tests/net/socket/af_packet to check couple of cases:
- we have a packet socket and UDP socket bound, and we receive a UDP packet to bound port (in this case the data should be delivered to both sockets)
- two sockets bound, but UDP is not listening the received data port, in this case only packet socket should receive data
at least these cases should be checked
64625dd to
9ee0de3
Compare
9ee0de3 to
66ce5e6
Compare
jukkar
reviewed
Jan 13, 2021
66ce5e6 to
61145ce
Compare
jukkar
reviewed
Jan 14, 2021
jukkar
reviewed
Jan 14, 2021
added 4 commits
January 14, 2021 16:13
…ocket The setup_socket() function calls socket() with proto changed to network order. In this case functions with zsock_* prefix are called instead of zpacket_*. The problem is with 'packet_is_supported()' method from sockets_packet.c, which returns false when ETH_P_ALL proto is converted with htons(). This patch fixes this issue by removing the htons() call. Signed-off-by: Lukasz Majewski <lukma@denx.de> Suggested-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
The new function - namely conn_raw_socket(); has been introduced to
handle raw sockets processing. Its code, up till now, only was
executed when IS_ENABLED(CONFIG_NET_SOCKETS_PACKET) was defined.
After this change it can be reused when one would like to handle
raw sockets also when CONFIG_NET_{UDP|TCP} are enabled.
Signed-off-by: Lukasz Majewski <lukma@denx.de>
This patch brings support for AF_PACKET and SOCK_RAW type of sockets. In net_conn_input() function the new flag has been introduced - 'raw_pkt_continue' to indicate if there are other than AF_PACKET connections registered. If we do not have other connections than AF_PACKET, the packet is solely handled in net_conn_input() (or to be more specific in its helper function - conn_raw_socket()). Otherwise, it is passed back to net_conn_input in IPv4/6 processing. Signed-off-by: Lukasz Majewski <lukma@denx.de>
The af_packet test has been augmented to check if sent UDP packet from one port to another (via net interface) is also passed to open SOCK_RAW connection. The test_packet_sockets() function has been reused to setup the SOCK_RAW sockets for this test. It is important to note that the packet is passed to receive part of net stack after being sent. Signed-off-by: Lukasz Majewski <lukma@denx.de>
61145ce to
7d773e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After those commits it will be possible to handle raw sockets in user programs when also UDP and TCP support is enabled.
It first moves eligible code to
conn_raw_socket()new function and afterwards reuses it also when UDP and TCP support isenabled.