Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Inventek es-WIFI serial bus and shield #29507

Merged
merged 5 commits into from
Nov 3, 2020

Conversation

nandojve
Copy link
Member

Add uart bus interface to extended esWIFI driver. This enables all Inventek's modules with IWIN AT Commands firmware.
Introduce Inventek's es-WIFI modules shield. This shield exposes es-WIFI driver using Arduino Uno R3 header by UART or SPI interfaces. It shows how user can create their own overlay and expose es-WIFI driver.
The current Inventek's EVB doesn't have all pins necessary to control the module by Arduino hearder. The docs shows how to wire to get ISM43xx EVB working by Arduino headers.
Add entries at samples: net: wifi to test shields variation at CI.

@nandojve nandojve marked this pull request as ready for review October 31, 2020 18:50
@nandojve nandojve changed the title WIP: Add Inventek es-WIFI serial bus and shield Add Inventek es-WIFI serial bus and shield Oct 31, 2020
@nandojve nandojve added this to the v2.5.0 milestone Oct 31, 2020
Copy link
Member

@jukkar jukkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, minor nit about wording

@loicpoulain
Copy link
Collaborator

It looks good, would you mind adding you as eswifi co-maintainer? since I cannot easily validate the UART bus variant on my side.

Remove global access to structure eswifi_spi_data variable.  Instead,
add a method to pass access to that structure.  This allows better
control to the data bus variable.

Signed-off-by: Gerson Fernando Budke <gerson.budke@atl-electronics.com>
The WIFI_ESWIFI_NAME config would be uselful when there is no device
tree alternative.  The esWIFI driver already is on device tree and the
label property exists.  This remove WIFI_ESWIFI_NAME Kconfig variable
and switch to device tree equivalent.

Signed-off-by: Gerson Fernando Budke <gerson.budke@atl-electronics.com>
Add uart bus interface to extended esWIFI driver.  This enables all
Inventek modules with IWIN AT Commands firmware.

Signed-off-by: Gerson Fernando Budke <gerson.budke@atl-electronics.com>
Add Inventek es-WIFI modules shield.  This shield exposes es-WIFI driver
using Arduino Uno R3 header by UART or SPI interfaces.  It shows how
user can create their own overlay and expose es-WIFI driver.

The current Inventek's EVB doesn't have all pins necessary to control
the module by Arduino hearder.  This shows how to wire to get ISM43xx
EVB working.

Signed-off-by: Gerson Fernando Budke <gerson.budke@atl-electronics.com>
The es-WIFI driver is used by Inventek's es-WIFI shields. This enables
wifi sample to build all variations to ensures that dependencies are
meet.

Signed-off-by: Gerson Fernando Budke <gerson.budke@atl-electronics.com>
@nandojve
Copy link
Member Author

nandojve commented Nov 2, 2020

Thanks @jukkar !

@loicpoulain , I can help to test serial bus, no problem.

@nandojve nandojve requested a review from jukkar November 2, 2020 13:17
Copy link
Member

@jukkar jukkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@carlescufi carlescufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlescufi carlescufi merged commit 3932011 into zephyrproject-rtos:master Nov 3, 2020
@nandojve nandojve deleted the atl/inventek branch November 3, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants