Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stm32h7 ethernet driver support #26226

Merged
merged 4 commits into from
Jul 21, 2020
Merged

stm32h7 ethernet driver support #26226

merged 4 commits into from
Jul 21, 2020

Conversation

KozhinovAlexander
Copy link
Collaborator

@KozhinovAlexander KozhinovAlexander commented Jun 16, 2020 •
edited
Loading

This was referenced Jun 16, 2020
Merged
Closed
@KozhinovAlexander KozhinovAlexander mentioned this pull request Jun 16, 2020
Closed
@erwango
Copy link
Member

erwango commented Jun 17, 2020

^^ @i-and, @KwonTae-young, @gmarull

@erwango erwango requested a review from ABOSTM June 17, 2020 07:23
gmarull
gmarull previously requested changes Jun 17, 2020
View reviewed changes
Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are a few style/code issues that should be fixed first.

jukkar
jukkar reviewed Jun 17, 2020
View reviewed changes
Copy link
Member

@jukkar jukkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some mostly cosmetic nits

@KozhinovAlexander KozhinovAlexander force-pushed the stm32h7_ethernet_driver_support#26174 branch 6 times, most recently from a7380f4 to 4c2dfe4 Compare June 19, 2020 22:24
@KozhinovAlexander KozhinovAlexander force-pushed the stm32h7_ethernet_driver_support#26174 branch 4 times, most recently from c10221f to f0d17f3 Compare June 20, 2020 17:15
@KozhinovAlexander KozhinovAlexander requested a review from jukkar June 21, 2020 08:25
@KozhinovAlexander KozhinovAlexander force-pushed the stm32h7_ethernet_driver_support#26174 branch 2 times, most recently from 7a3f244 to 3d35a32 Compare June 21, 2020 10:12
@KozhinovAlexander KozhinovAlexander force-pushed the stm32h7_ethernet_driver_support#26174 branch 2 times, most recently from 4f1c0fa to 065c385 Compare July 20, 2020 10:53
@erwango
Copy link
Member

erwango commented Jul 20, 2020

@Nukersson can you check the CI failure ?

@erwango erwango added the DNM This PR should not be merged (Do Not Merge) label Jul 20, 2020
@erwango
Copy link
Member

erwango commented Jul 20, 2020

Tagging DNM to avoid accidental merge until CI is fixed

@KozhinovAlexander
Copy link
Collaborator Author

@Nukersson can you check the CI failure ?

Will be fixed today evening. Can't do it until then.

1 similar comment
@KozhinovAlexander
Copy link
Collaborator Author

@Nukersson can you check the CI failure ?

Will be fixed today evening. Can't do it until then.

@KozhinovAlexander KozhinovAlexander force-pushed the stm32h7_ethernet_driver_support#26174 branch 2 times, most recently from 165dd56 to 9851b25 Compare July 20, 2020 20:56
@KozhinovAlexander
Copy link
Collaborator Author

KozhinovAlexander commented Jul 20, 2020 •
edited
Loading

@Nukersson can you check the CI failure ?

@erwango CI test fixed. Checks are passing. Please remove DNM, if possible.

erwango
erwango requested changes Jul 21, 2020
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last mile..

@KozhinovAlexander KozhinovAlexander force-pushed the stm32h7_ethernet_driver_support#26174 branch 2 times, most recently from 8c9528b to 7c30944 Compare July 21, 2020 10:47
@erwango erwango removed the DNM This PR should not be merged (Do Not Merge) label Jul 21, 2020
Alexander Kozhinov added 4 commits July 21, 2020 11:14
drivers: pinumx: stm32: pinmux_stm32h7: added ethernet pins
7c49a3e 
added ethernet pins definition for stm32h7 SoC series

Signed-off-by: Alexander Kozhinov <AlexanderKozhinov@yandex.com>
drivers: ethernet: stm32: pre-add stm32h7 support
65400ca 
added changes that apply to other than stm32h7 series
and prepares stm32h7 series integration:

eth_tx/eth_rx: changed type of total_len
added necessary defines for
    tx_desc and own flag extractions
added read_eth_phy_register() function
    and corresponding defines
added ETH_DMA_MEM and CACHE defines
following memory buffers declarations moved out of
    its ifdef preprocessor macro:
        dma_rx_desc_tab, dma_tx_desc_tab,
        dma_rx_buffer, dma_tx_buffer
added hal_ret stm32 HAL status checks

Signed-off-by: Alexander Kozhinov <AlexanderKozhinov@yandex.com>
drivers: ethernet: stm32: add stm32h7 support
ae40e44 
add DTCM caching management in KConfig for stm32h7
add NOCACHE_MEMORY support for stm32h7 M7 CPU series
add HAL_RCC_EX support for stm32h7 series
implemented stm32h7 support within stm32 eth driver

Signed-off-by: Alexander Kozhinov <AlexanderKozhinov@yandex.com>
boards: nucleo_h745zi_q: added ethernet support
6b5187c 
KConfig.defconfig: enabled NETWORKING support
pinmux.c: added ethernet pins definition for this board
m7 yaml file becomes netif:eth support enabled

Signed-off-by: Alexander Kozhinov <AlexanderKozhinov@yandex.com>
@KozhinovAlexander KozhinovAlexander force-pushed the stm32h7_ethernet_driver_support#26174 branch from 7c30944 to 6b5187c Compare July 21, 2020 11:14
@carlescufi carlescufi merged commit 08b557e into zephyrproject-rtos:master Jul 21, 2020
@lochej
Copy link
Collaborator

lochej commented Jul 21, 2020

Congrats @Nukersson for this PR, the next step is for us to open another PR to add my interrupt based method to the driver 😄

@KozhinovAlexander
Copy link
Collaborator Author

KozhinovAlexander commented Jul 21, 2020 •
edited
Loading

Congrats @Nukersson for this PR, the next step is for us to open another PR to add my interrupt based method to the driver 😄

Thanks. I will prepare it and contact you later.

@KozhinovAlexander KozhinovAlexander deleted the stm32h7_ethernet_driver_support#26174 branch July 21, 2020 14:05
@KozhinovAlexander KozhinovAlexander restored the stm32h7_ethernet_driver_support#26174 branch July 21, 2020 14:14
@KozhinovAlexander KozhinovAlexander deleted the stm32h7_ethernet_driver_support#26174 branch July 21, 2020 14:17
@lochej lochej mentioned this pull request Jul 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwango erwango erwango approved these changes

@gmarull gmarull gmarull approved these changes

@ABOSTM ABOSTM ABOSTM approved these changes

@nashif nashif Awaiting requested review from nashif

@pfalcon pfalcon Awaiting requested review from pfalcon

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

@jukkar jukkar Awaiting requested review from jukkar

@galak galak Awaiting requested review from galak

@carlescufi carlescufi Awaiting requested review from carlescufi

Assignees
No one assigned
Labels
area: Boards area: Devicetree area: Ethernet platform: STM32 ST Micro STM32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@KozhinovAlexander @erwango @ABOSTM @lochej @pfalcon @carlescufi @jukkar @gmarull @zephyrbot