devicetree: Add helper macros for GPIO element/array initialization #23795
Conversation
Pull helper macros out of tests/lib/devicetree/src/main.c and make them generally available for drivers or applications to utilize. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
|
This is need for use in |
| * @return a struct initializer for the give index "idx" into the | ||
| * "phandle-array" gpio_pha | ||
| */ | ||
| #define DT_GPIO_ELEM(idx, node_id, gpio_pha) \ |
There was a problem hiding this comment.
What do you think about the name DT_GPIO_LPF_AT_IDX?
The other phandle array macros also take arguments in (node_id, gpio_pha, idx) order.
There was a problem hiding this comment.
DT_GPIO_CELLS_AT_IDX would be more consistent with the underlying devicetree terminology and would be highlight the similarity with other phandle-valued aggregates. I really find _LPF_ to be obscure. (Pins, Flags, what is L?)
There was a problem hiding this comment.
OK, not obvious especially if label goes away. I'd rather find a name that covers all phandle+specifiers so we can use it consistently for DT_PWM_, DT_IOCHANNEL_, .... CELLS ignores the phandle, so maybe DT_GPIO_PHCELLS_? Ideally when the phandle reference changes from a label to an identifier we wouldn't have to change the name, just the definition of the macro and of the structure into which it should be stored.
But really this PR is jumping to a partial solution for #23691 without addressing the other part: eliminating the custom struct sx1276_dio. We do not need a global macro creating precedent and adding new names to convert lora/sx1276.c; that file can use a local define as I did in #23245 (review)
| * type "phandle-array" | ||
| * @return an array initializer for the given "phandle-array" gpio_pha | ||
| */ | ||
| #define DT_GPIO_LISTIFY(node_id, gpio_pha) \ |
There was a problem hiding this comment.
Would it be better to let the user pass the macro here as an argument instead of assuming DT_GPIO_ELEM? Keeps the API generic in cases where it's not a label/pin/flags always.
There was a problem hiding this comment.
I would strongly prefer a solution that solves #23691 generally (including the data structure), rather than just the macro and just for one driver API. Only two in-tree files use the DT_FOO_GPIOS initializer macro: lora/sx1276 and samples/boards/nrf/battery/src/battery.c. Both can be accommodated by in-file local definitions of a similar macro.
The battery sample also needs one for DT_FOO_IO_CHANNELS.
|
Going to close this, and just implement a driver specific macro for lora/sx1276 |
Pull helper macros out of tests/lib/devicetree/src/main.c and make them
generally available for drivers or applications to utilize.
Signed-off-by: Kumar Gala kumar.gala@linaro.org