USB: check MPS depending on USB speed and endpoint type (Fix Coverity issues #14977) #15147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include to the callback parameters also alt_setting to be able to make right choice for ECM. Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Only enable netusb for the right configuration of interface and alt_setting. Fixes zephyrproject-rtos#13560 Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Refactor code making set_endpoint() helper which check validity of input parameters. At the moment FS USB is supported, for future we also need to add HS part. Fix bug with usb_set_configuration() always returning true. Fixes zephyrproject-rtos#14954 Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Use helper set_endpoint() for endpoint configuration. Fixes zephyrproject-rtos#14957 Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
|
All checks are passing now. Review history of this comment for details about previous failed status. |
finikorg
reviewed
Apr 3, 2019
There was a problem hiding this comment.
I think we can make simper, just
diff --git a/include/usb/usb_device.h b/include/usb/usb_device.h
index 9546bfad25..5ea2617888 100644
--- a/include/usb/usb_device.h
+++ b/include/usb/usb_device.h
@@ -74,6 +74,16 @@ extern "C" {
#define MAX_PACKET_SIZE0 64 /**< maximum packet size for EP 0 */
+#if DT_USBHS_MAXIMUM_SPEED == USB_MAXIMUM_SPEED_HIGH_SPEED
+#define USB_MAX_BULK_MPS 512
+#define USB_MAX_INT_MPS 1024
+#define USB_MAX_ISO_MPS 1024
+#else /* For every other configuartions for now */
+#define USB_MAX_BULK_MPS 64
+#define USB_MAX_INT_MPS 64
+#define USB_MAX_ISO_MPS 1023
+#endif
+
/*************************************************************************
* USB application interface
**************************************************************************/
b441bba68a64a3ba8a6f389b4845b8878d632921
That DTS a bit screwed up, I think every board reinvent its own maximum speed definition.
Add maximum packet size for different endpoint types and usb speed modes. Signed-off-by: Johann Fischer <j.fischer@phytec.de>
Check MPS depending on USB speed and endpoint type. Signed-off-by: Johann Fischer <j.fischer@phytec.de>
9657a10 to
76db184
Compare
|
close it, I have an other fix in mind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check MPS depending on USB speed and endpoint type.
This is based on #14977 and #15140, for a discussion how it could be done.
@finikorg You can cherry-pick or rebase it as you wish.