Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USB: Fixes for stm32 driver #14925

Merged
merged 2 commits into from
Apr 5, 2019
Merged

Conversation

finikorg
Copy link
Collaborator

Cherry picked from another PR

Fix build error when executing sanitycheck on stm32 devices.

Command to execute tests:
sanitycheck --device-testing --device-serial /dev/ttyACM0 -p <board>
    -t usb

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Fix crash when reading invalid endpoint found in harness test.

Fixes zephyrproject-rtos#13560

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
@finikorg finikorg added area: USB Universal Serial Bus platform: STM32 ST Micro STM32 labels Mar 27, 2019
@codecov-io
Copy link

Codecov Report

Merging #14925 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14925   +/-   ##
=======================================
  Coverage   52.93%   52.93%           
=======================================
  Files         309      309           
  Lines       45251    45251           
  Branches    10447    10447           
=======================================
  Hits        23953    23953           
  Misses      16533    16533           
  Partials     4765     4765

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f011c9...e42d78f. Read the comment docs.

Copy link
Collaborator

@ydamigos ydamigos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@finikorg We should check if ep_state isn't null but I don't think that e42d78f fixes #13560.

@finikorg
Copy link
Collaborator Author

@finikorg We should check if ep_state isn't null but I don't think that e42d78f fixes #13560.

There is another fix also for that Issue. This exact patch fixes crash mentioned there.

@galak galak added this to the v1.14.0 milestone Mar 28, 2019
Copy link
Collaborator

@ydamigos ydamigos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@galak galak added the bug The issue is a bug, or the PR is fixing a bug label Mar 28, 2019
@galak
Copy link
Collaborator

galak commented Mar 28, 2019

If you desire this fix in 1.14, please open or associate this PR with an Issue.

@galak galak removed this from the v1.14.0 milestone Mar 28, 2019
@carlescufi
Copy link
Member

@finikorg do we need this for 1.14? What PR is this cherry-picked from?

@finikorg
Copy link
Collaborator Author

finikorg commented Apr 3, 2019

cherr-picked from harness PR #14874

@jfischer-no jfischer-no self-requested a review April 5, 2019 13:57
@jfischer-no jfischer-no added this to the v1.14.0 milestone Apr 5, 2019
@nashif nashif merged commit 8ed215e into zephyrproject-rtos:master Apr 5, 2019
@finikorg finikorg deleted the test-stm32 branch July 14, 2020 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: USB Universal Serial Bus bug The issue is a bug, or the PR is fixing a bug platform: STM32 ST Micro STM32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants