Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: disco: Using generic board configuration. #11983

Closed
wants to merge 2 commits into from

Conversation

cybertale
Copy link
Collaborator

This example used to use some board-related stuff.
Replace them with some generic definitions.

Signed-off-by: Song Qiang songqiang1304521@gmail.com

This example used to use some board-related stuff.
Replace them with some generic definitions.

Signed-off-by: Song Qiang <songqiang1304521@gmail.com>
@codecov-io
Copy link

codecov-io commented Dec 10, 2018

Codecov Report

Merging #11983 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11983   +/-   ##
=======================================
  Coverage   48.13%   48.13%           
=======================================
  Files         281      281           
  Lines       43425    43425           
  Branches    10406    10406           
=======================================
  Hits        20902    20902           
  Misses      18368    18368           
  Partials     4155     4155

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e7c916...b887378. Read the comment docs.

@cybertale cybertale requested a review from dbkinder as a code owner December 10, 2018 11:32
@zephyrbot
Copy link
Collaborator

zephyrbot commented Dec 10, 2018

All checks are passing now.

Review history of this comment for details about previous failed status.
Note that some checks might have not completed yet.

@cybertale cybertale force-pushed the disco_generic branch 2 times, most recently from 0c8d3c4 to 3019663 Compare December 10, 2018 12:26
Addply the code changes in README.rst for doc.

Signed-off-by: Song Qiang <songqiang1304521@gmail.com>
@nashif
Copy link
Member

nashif commented Dec 10, 2018

This is already being addressed in #11800

@cybertale cybertale closed this Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants