Add lsm6dsl specific samples + change its dts binding #11848

avisconti · 2018-12-04T16:48:22Z

This PR is composed by 3 commits, all 3 somehow related to lsm6dsl sensor.

avisconti · 2018-12-04T16:49:32Z

@galak @MaureenHelm
If you can also provide your inputs would be good!

zephyrbot · 2018-12-04T16:53:32Z

All checks are passing now.

Review history of this comment for details about previous failed status.
Note that some checks might have not completed yet.

codecov-io · 2018-12-04T17:46:04Z

Codecov Report

Merging #11848 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #11848   +/-   ##
=======================================
  Coverage   53.94%   53.94%           
=======================================
  Files         242      242           
  Lines       27654    27654           
  Branches     6717     6717           
=======================================
  Hits        14917    14917           
  Misses       9932     9932           
  Partials     2805     2805

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87cf468...5f70824. Read the comment docs.

dbkinder

Thanks for the documentation, one little tweak.

dbkinder · 2018-12-04T19:12:42Z

samples/sensor/lsm6dsl/README.rst

+References
+**********
+
+ - LSM6DSL http://www.st.com/en/mems-and-sensors/lsm6dsl.html


Rendering is better without the leading space:

Suggested change

- LSM6DSL http://www.st.com/en/mems-and-sensors/lsm6dsl.html

- LSM6DSL http://www.st.com/en/mems-and-sensors/lsm6dsl.html

erwango

Seems in conflict with #11854. Can you have a check?

avisconti · 2018-12-05T09:36:04Z

@erwango

Seems in conflict with #11854. Can you have a check?

Yes, I already noticed it, as @galak added me in the review of #11854.
Actually, I have also to change the commit (just meged) for lis2dh as well have the one for lis3dh (currently under review #11814)

avisconti · 2018-12-05T12:05:51Z

I have repushed it on top of #11854. Now both i2c and spi yaml file are using same compatible
string. Moreover I took care of the inputs from @dbkinder on README doc file.

galak · 2018-12-05T15:08:37Z

Going to mark this DNM for now until #11854 goes in.

dbkinder

doc changes LGTM, thanks!

galak · 2018-12-07T18:37:06Z

Can you rebase now that we merged #11854

avisconti · 2018-12-10T09:10:20Z

Can you rebase now that we merged #11854

done!

avisconti · 2018-12-10T10:01:20Z

recheck

avisconti · 2018-12-10T12:09:05Z

@galak
Am I the only one who is getting this error during CI?

L/home/buildslave/src/github.com/zephyrproject-rtos/zephyr/out-3nd-pass/disco_l475_iot1/samples/net/wifi/test/zephyr -lgcc -Wl,--print-memory-usage -mthumb -nostdlib -static -no-pie --coverage -Wl,-X -Wl,-N -Wl,--gc-sections -Wl,--build-id=none -Wl,--orphan-handling=warn -mabi=aapcs && :
Memory region Used Size Region Size %age Used
FLASH: 81788 B 1 MB 7.80%
SRAM: 32640 B 96 KB 33.20%
IDT_LIST: 184 B 2 KB 8.98zephyr/libzephyr.a(eswifi_bus_spi.c.obj):(.data.eswifi_bus_ops_spi+0x0): multiple definition of eswifi_bus_ops_spi' zephyr/libzephyr.a(eswifi_core.c.obj):(.bss.eswifi_bus_ops_spi+0x0): first defined here zephyr/libzephyr.a(eswifi_bus_spi.c.obj): In function eswifi_spi_init':
/home/buildslave/src/github.com/zephyrproject-rtos/zephyr/drivers/wifi/eswifi/eswifi_bus_spi.c:101: multiple definition of uarthost' zephyr/libzephyr.a(eswifi_core.c.obj):/home/buildslave/src/github.com/zephyrproject-rtos/zephyr/drivers/wifi/eswifi/eswifi_core.c:294: first defined here zephyr/libzephyr.a(eswifi_offload.c.obj):(.bss.eswifi_bus_ops_spi+0x0): multiple definition of eswifi_bus_ops_spi'
zephyr/libzephyr.a(eswifi_core.c.obj):/home/buildslave/src/github.com/zephyrproject-rtos/zephyr/drivers/wifi/eswifi/eswifi_core.c:294: first defined here
zephyr/libzephyr.a(eswifi_offload.c.obj): In function eswifi_off_accept': /home/buildslave/src/github.com/zephyrproject-rtos/zephyr/drivers/wifi/eswifi/eswifi_offload.c:88: multiple definition of uarthost'
zephyr/libzephyr.a(eswifi_core.c.obj):/home/buildslave/src/github.com/zephyrproject-rtos/zephyr/drivers/wifi/eswifi/eswifi_core.c:294: first defined here
collect2: error: ld returned 1 exit status
%
ninja: build stopped: subcommand failed.

galak · 2018-12-10T13:53:59Z

@galak
Am I the only one who is getting this error during CI?

Nope, you aren't. Looking to see how this happened.

galak · 2018-12-10T14:16:13Z

Nope, you aren't. Looking to see how this happened.

Fix in PR #11988

avisconti · 2018-12-10T14:22:45Z

Fix in PR #11988

OK, I'll wait for the merge of that PR

avisconti · 2018-12-11T16:51:10Z

Merged!

galak

Just noticed, and while not directly related CONFIG_LSM6DSL_BUS_TYPE we should be able to replace with {DT_ST_LSM6DSL_BUS_I2C and/or DT_ST_LSM6DSL_BUS_SPI} that are now generated.

galak

The sample never gets built for an platform via sanitycheck:

./scripts/sanitycheck -T samples/sensor/lsm6dsl/

I wondering if we can wait for #11800 and than use a filter on DT_COMPAT_ST_LSM6DSL

avisconti · 2018-12-14T13:24:08Z

@galak

Just noticed, and while not directly related CONFIG_LSM6DSL_BUS_TYPE we should be able to
replace with {DT_ST_LSM6DSL_BUS_I2C and/or DT_ST_LSM6DSL_BUS_SPI} that are now
generated.

sure! I didn't notice it.
I'll do it in a separate PR.
thanks!

EDIT:
opened PR #12105

avisconti · 2018-12-14T13:26:19Z

@galak

The sample never gets built for an platform via sanitycheck:
./scripts/sanitycheck -T samples/sensor/lsm6dsl/
I wondering if we can wait for #11800 and than use a filter on DT_COMPAT_ST_LSM6DSL

PR #11800 has been integrated, but I'm not sure I got what these filters are about...
Is this for CI?

avisconti · 2018-12-14T15:13:12Z

This PR has been rebased onto #12105
Must wait til that one will be merged

avisconti · 2019-01-09T13:17:02Z

rebased after #12105 merging.
@galak
I added DT_COMPAT_ST_LSM6DSL filter in sample.yaml, but still it seems sanitycheck is never
called for any platform. I'm not so familiar with this scripts, so I may need an help from you.

galak · 2019-01-18T15:25:15Z

samples/sensor/lsm6dsl/sample.yaml

+  name: LSM6DSL accelerometer and gyrometer sensor
+tests:
+  test:
+    filter: DT_COMPAT_ST_LSM6DSL


remove the filter:

galak

You need to add 'lsm6dsl' to the board yaml that support it.

Add the irq-gpios property to LSM6DSL sensor yaml description file for I2C case. Signed-off-by: Armando Visconti <armando.visconti@st.com>

avisconti · 2019-01-21T10:05:49Z

@galak

you need to add 'lsm6dsl' to the board yaml that support it.

removed the filter and added lsm6dsl to ArgonKey board.
Then re-based and re-pushed!
Thx for your support.

erwango

2 minor comments, otherwise tested ok

erwango · 2019-01-21T14:17:24Z

boards/arm/96b_argonkey/96b_argonkey.yaml

@@ -14,4 +14,7 @@ supported:
  - hts221
  - rtc
  - spi
+  - lsm6dsl


Can you add it in disco_l475_iot1 as well?

erwango · 2019-01-21T14:21:21Z

samples/sensor/lsm6dsl/src/main.c

+	}
+
+	while (1) {
+		/* lsm6dsl accel */


Can you add following to ease result view:

/* Erase previous */ printf("\0033\014");

Provide through the dts the gpio on which the lsm6dsl INT1 is connected. Enable also the lsm6dsl trigger mode. Signed-off-by: Armando Visconti <armando.visconti@st.com>

Add LPS22HB and LSM6DSL sensors to yaml file. Signed-off-by: Armando Visconti <armando.visconti@st.com>

Add supported sensor to yaml file. The ArgonKey board supports following sensors: - HTS221 (humidity) - LPS22HB (pressure) - LSM6DSL (imu) - VL53L0X (proximity) Signed-off-by: Armando Visconti <armando.visconti@st.com>

This commit provides sample application for sensor lsm6dsl. This sample has been tested on both 96b_argonkey board, where lsm6dsl is connect to the micro thru SPI bus, and on disco_l475_iot1 board, where instead it is connected to I2C bus. Signed-off-by: Armando Visconti <armando.visconti@st.com>

avisconti · 2019-01-22T13:58:12Z

Modified according to @erwango observation and re-pushed.

avisconti requested review from dbkinder and erwango as code owners December 4, 2018 16:48

avisconti added area: ARM ARM (32-bit) Architecture area: Samples Samples area: Devicetree area: Sensors Sensors labels Dec 4, 2018

avisconti force-pushed the lsm6dsl-dts-i2c branch from 86771fc to cfecc76 Compare December 4, 2018 17:00

dbkinder suggested changes Dec 4, 2018

View reviewed changes

erwango reviewed Dec 5, 2018

View reviewed changes

avisconti force-pushed the lsm6dsl-dts-i2c branch from cfecc76 to c7d108e Compare December 5, 2018 12:03

galak added the DNM This PR should not be merged (Do Not Merge) label Dec 5, 2018

galak self-assigned this Dec 5, 2018

dbkinder approved these changes Dec 5, 2018

View reviewed changes

galak removed the DNM This PR should not be merged (Do Not Merge) label Dec 7, 2018

avisconti force-pushed the lsm6dsl-dts-i2c branch from c7d108e to b80a510 Compare December 10, 2018 09:09

avisconti force-pushed the lsm6dsl-dts-i2c branch from b80a510 to af9f267 Compare December 11, 2018 16:50

galak reviewed Dec 11, 2018

View reviewed changes

galak requested changes Dec 11, 2018

View reviewed changes

avisconti force-pushed the lsm6dsl-dts-i2c branch from af9f267 to 1b67e9e Compare December 14, 2018 15:12

avisconti force-pushed the lsm6dsl-dts-i2c branch from 1b67e9e to 55d0892 Compare December 20, 2018 09:29

avisconti force-pushed the lsm6dsl-dts-i2c branch from 55d0892 to b1c07ec Compare January 9, 2019 09:08

galak reviewed Jan 18, 2019

View reviewed changes

galak requested changes Jan 18, 2019

View reviewed changes

dts: sensor: lsm6dsl-i2c: Add irq-gpios property

888c4cc

Add the irq-gpios property to LSM6DSL sensor yaml description file for I2C case. Signed-off-by: Armando Visconti <armando.visconti@st.com>

avisconti force-pushed the lsm6dsl-dts-i2c branch from b1c07ec to 8b0a756 Compare January 21, 2019 10:04

erwango requested changes Jan 21, 2019

View reviewed changes

avisconti added 4 commits January 22, 2019 14:43

boards/arm: disco_l475_iot1: Add lsm6dsl int gpio info in dts

a7cade5

Provide through the dts the gpio on which the lsm6dsl INT1 is connected. Enable also the lsm6dsl trigger mode. Signed-off-by: Armando Visconti <armando.visconti@st.com>

boards/arm: disco_l475_iot1: add supported sensors to yaml file

1ea7e10

Add LPS22HB and LSM6DSL sensors to yaml file. Signed-off-by: Armando Visconti <armando.visconti@st.com>

boards/arm: 96b_argonkey: add supported sensors to yaml file

e85a004

Add supported sensor to yaml file. The ArgonKey board supports following sensors: - HTS221 (humidity) - LPS22HB (pressure) - LSM6DSL (imu) - VL53L0X (proximity) Signed-off-by: Armando Visconti <armando.visconti@st.com>

avisconti force-pushed the lsm6dsl-dts-i2c branch from 8b0a756 to 5f70824 Compare January 22, 2019 13:56

erwango approved these changes Jan 22, 2019

View reviewed changes

galak approved these changes Jan 23, 2019

View reviewed changes

galak merged commit b8d2e19 into zephyrproject-rtos:master Jan 23, 2019

avisconti deleted the lsm6dsl-dts-i2c branch January 23, 2019 10:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add lsm6dsl specific samples + change its dts binding #11848

Add lsm6dsl specific samples + change its dts binding #11848

avisconti commented Dec 4, 2018

avisconti commented Dec 4, 2018

zephyrbot commented Dec 4, 2018 •

edited

Loading

codecov-io commented Dec 4, 2018 •

edited

Loading

dbkinder left a comment

dbkinder Dec 4, 2018

avisconti Dec 5, 2018

erwango left a comment

avisconti commented Dec 5, 2018

avisconti commented Dec 5, 2018

galak commented Dec 5, 2018

dbkinder left a comment

galak commented Dec 7, 2018

avisconti commented Dec 10, 2018

avisconti commented Dec 10, 2018

avisconti commented Dec 10, 2018 •

edited

Loading

galak commented Dec 10, 2018

galak commented Dec 10, 2018

avisconti commented Dec 10, 2018

avisconti commented Dec 11, 2018

galak left a comment

galak left a comment

avisconti commented Dec 14, 2018 •

edited

Loading

avisconti commented Dec 14, 2018

avisconti commented Dec 14, 2018

avisconti commented Jan 9, 2019

galak Jan 18, 2019

galak left a comment

avisconti commented Jan 21, 2019

erwango left a comment

erwango Jan 21, 2019

avisconti Jan 22, 2019

erwango Jan 21, 2019

avisconti Jan 22, 2019

avisconti commented Jan 22, 2019

	- LSM6DSL http://www.st.com/en/mems-and-sensors/lsm6dsl.html
	- LSM6DSL http://www.st.com/en/mems-and-sensors/lsm6dsl.html

@@ @@ -14,4 +14,7 @@ supported: @@
                 - hts221
                 - rtc
                 - spi
+                - lsm6dsl

Add lsm6dsl specific samples + change its dts binding #11848

Add lsm6dsl specific samples + change its dts binding #11848

Conversation

avisconti commented Dec 4, 2018

avisconti commented Dec 4, 2018

zephyrbot commented Dec 4, 2018 • edited Loading

codecov-io commented Dec 4, 2018 • edited Loading

Codecov Report

dbkinder left a comment

Choose a reason for hiding this comment

dbkinder Dec 4, 2018

Choose a reason for hiding this comment

avisconti Dec 5, 2018

Choose a reason for hiding this comment

erwango left a comment

Choose a reason for hiding this comment

avisconti commented Dec 5, 2018

avisconti commented Dec 5, 2018

galak commented Dec 5, 2018

dbkinder left a comment

Choose a reason for hiding this comment

galak commented Dec 7, 2018

avisconti commented Dec 10, 2018

avisconti commented Dec 10, 2018

avisconti commented Dec 10, 2018 • edited Loading

galak commented Dec 10, 2018

galak commented Dec 10, 2018

avisconti commented Dec 10, 2018

avisconti commented Dec 11, 2018

galak left a comment

Choose a reason for hiding this comment

galak left a comment

Choose a reason for hiding this comment

avisconti commented Dec 14, 2018 • edited Loading

avisconti commented Dec 14, 2018

avisconti commented Dec 14, 2018

avisconti commented Jan 9, 2019

galak Jan 18, 2019

Choose a reason for hiding this comment

galak left a comment

Choose a reason for hiding this comment

avisconti commented Jan 21, 2019

erwango left a comment

Choose a reason for hiding this comment

erwango Jan 21, 2019

Choose a reason for hiding this comment

avisconti Jan 22, 2019

Choose a reason for hiding this comment

erwango Jan 21, 2019

Choose a reason for hiding this comment

avisconti Jan 22, 2019

Choose a reason for hiding this comment

avisconti commented Jan 22, 2019

zephyrbot commented Dec 4, 2018 •

edited

Loading

codecov-io commented Dec 4, 2018 •

edited

Loading

avisconti commented Dec 10, 2018 •

edited

Loading

avisconti commented Dec 14, 2018 •

edited

Loading