samples: logger: test sample in CI #10163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10163 +/- ##
==========================================
+ Coverage 53% 53.14% +0.13%
==========================================
Files 210 210
Lines 25732 25745 +13
Branches 5672 5673 +1
==========================================
+ Hits 13639 13681 +42
+ Misses 9779 9754 -25
+ Partials 2314 2310 -4
Continue to review full report at Codecov.
|
nordic-krch
reviewed
Sep 24, 2018
| @@ -29,6 +28,10 @@ SAMPLE_INSTANCE_DEFINE(inst1); | |||
| #define INST2_NAME STRINGIFY(SAMPLE_INSTANCE_NAME.inst2) | |||
| SAMPLE_INSTANCE_DEFINE(inst2); | |||
|
|
|||
| #ifndef NRF_RTC1 | |||
There was a problem hiding this comment.
#ifdef CONFIG_SOC_FAMILY_NRF would be better
pizi-nordic
approved these changes
Sep 24, 2018
|
recheck |
Add test stub for this sample to verify it in CI on default platforms. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
The way uart console is setup for this is not compatible with the logger and needs additional changes, excluding until we have this implemented in a generic way. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
55efc3f to
3083cb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test stub for this sample to verify it in CI on default platforms.
Signed-off-by: Anas Nashif anas.nashif@intel.com