Port fs commands to the new shell #10103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #10103 +/- ##
=======================================
Coverage 53.18% 53.18%
=======================================
Files 210 210
Lines 25816 25816
Branches 5682 5682
=======================================
Hits 13731 13731
Misses 9780 9780
Partials 2305 2305Continue to review full report at Codecov.
|
jakub-uC
reviewed
Sep 19, 2018
subsys/fs/shell.c
Outdated
| buf[i] > 127 ? '.' : buf[i]); | ||
| } | ||
|
|
||
| printk("\n"); | ||
| shell_fprintf(shell, SHELL_NORMAL, "\n"); |
subsys/fs/shell.c
Outdated
| return res; | ||
| shell_fprintf(shell, SHELL_ERROR, | ||
| "Error creating dir[%d]\r\n", res); | ||
| return; |
30be5d6 to
e93d9ba
Compare
|
@nvlsianpu can you take a look at this? |
jakub-uC
approved these changes
Sep 26, 2018
|
sure |
nashif
approved these changes
Sep 27, 2018
nvlsianpu
requested changes
Sep 27, 2018
subsys/fs/shell.c
Outdated
| @@ -147,20 +265,24 @@ static int cmd_read(int argc, char *argv[]) | |||
|
|
|||
| err = fs_stat(path, &dirent); | |||
| if (err) { | |||
| printk("Failed to stat %s (%d)\n", path, err); | |||
| return err; | |||
| shell_fprintf(shell, SHELL_ERROR, "Failed to stat %s (%d)\r\n", | |||
There was a problem hiding this comment.
error message: "Failed to obtain/get file/file-system object status"
There was a problem hiding this comment.
I understand that message was inherited :D
There was a problem hiding this comment.
yes, i didn't touch messages but i fixed that one on your request :)
|
@nordic-krch : May you plesae rebase to this PR:#10322? |
jakub-uC
requested changes
Oct 2, 2018
Port existing commands to the new shell subsystem. Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
|
rebased on master (including #10322 |
jakub-uC
approved these changes
Oct 11, 2018
nvlsianpu
approved these changes
Oct 11, 2018
carlescufi
approved these changes
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post shell fs commands to the new shell.
It has changes on top of #9362
Fixes #8874.