Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: drivers: espi: Need to handle failures in temperature retrieval #32457

Closed
albertofloyd opened this issue Feb 18, 2021 · 0 comments · Fixed by #34109
Closed

samples: drivers: espi: Need to handle failures in temperature retrieval #32457

albertofloyd opened this issue Feb 18, 2021 · 0 comments · Fixed by #34109
Assignees
@albertofloyd
Labels
Enhancement Changes/Updates/Additions to existing features

Comments

@albertofloyd
Copy link
Collaborator

Is your enhancement proposal related to a problem? Please describe.
The current sample code assumes there are no failures while retrieving temperature over eSPI OOB channel

Describe the solution you'd like
If N consecutive attempts fail then it exist the thread and indicate the failure

Impact
If sample code ever gets into CI it would hang if any failing conditions
@albertofloyd albertofloyd added the Enhancement Changes/Updates/Additions to existing features label Feb 18, 2021
@albertofloyd albertofloyd self-assigned this Feb 18, 2021
@albertofloyd albertofloyd changed the title samples: drivers: espi: samples: drivers: espi: Need to handle failures in temperature retrieval Feb 18, 2021
@albertofloyd albertofloyd mentioned this issue Feb 18, 2021
Merged
albertofloyd added a commit to albertofloyd/zephyr that referenced this issue Apr 13, 2021
@albertofloyd
samples: drivers: espi: Ensure sample code thread exits
204d9cd 
Fix zephyrproject-rtos#32457 by decreasing iterations on failure too.

Signed-off-by: Jose Alberto Meza <jose.a.meza.arellano@intel.com>
@albertofloyd albertofloyd mentioned this issue Apr 13, 2021
Merged
nashif pushed a commit that referenced this issue Apr 13, 2021
@albertofloyd @nashif
samples: drivers: espi: Ensure sample code thread exits
11cb2e5 
Fix #32457 by decreasing iterations on failure too.

Signed-off-by: Jose Alberto Meza <jose.a.meza.arellano@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albertofloyd albertofloyd

Labels
Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

drivers: espi: xec: Reduce buffer allocation to minimum required albertofloyd/zephyr
1 participant
@albertofloyd