Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitycheck filtering broken #20371

Closed
aescolar opened this issue Nov 6, 2019 · 1 comment · Fixed by #20373
Closed

Sanitycheck filtering broken #20371

aescolar opened this issue Nov 6, 2019 · 1 comment · Fixed by #20373
Assignees
@galak
Labels
area: Sanitycheck Sanitycheck has been renamed to Twister bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug

Comments

@aescolar
Copy link
Member

aescolar commented Nov 6, 2019 •
edited
Loading

As of now, in the master branch, the sanitycheck filtering is broken for boards without DTS, as some tests will be unfiltered if the board does not have DTS info (the default behavior should probably have been the opposite, but never mind that now)

This was introduced in #20204, and partially fixed in #20365

For more info see #20119 (comment)
@aescolar aescolar added bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug area: Sanitycheck Sanitycheck has been renamed to Twister labels Nov 6, 2019
@aescolar aescolar self-assigned this Nov 6, 2019
@aescolar aescolar mentioned this issue Nov 6, 2019
Closed
galak added a commit to galak/zephyr that referenced this issue Nov 6, 2019
@galak
sanitycheck: fix filtering for boards without DTS
4bf98f8 
If we don't have a DTS (like nrf52_bsim) we shouldn't try and create an
EDT, but we still need to call expr_parser.parse to filter testcases.
So move the os.path.exists(dts_path) around the creation of the EDT.

Fixes: zephyrproject-rtos#20371

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
@galak galak mentioned this issue Nov 6, 2019
Merged
@aescolar aescolar assigned galak and unassigned aescolar Nov 6, 2019
@aescolar
Copy link
Member Author

aescolar commented Nov 6, 2019

By the way @stephanosio , thanks for bisecting and narrowing the issue down.

aescolar pushed a commit that referenced this issue Nov 6, 2019
@galak @aescolar
sanitycheck: fix filtering for boards without DTS
ae88e44 
If we don't have a DTS (like nrf52_bsim) we shouldn't try and create an
EDT, but we still need to call expr_parser.parse to filter testcases.
So move the os.path.exists(dts_path) around the creation of the EDT.

Fixes: #20371

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galak galak

Labels
area: Sanitycheck Sanitycheck has been renamed to Twister bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug
Projects
None yet
Milestone
No milestone
2 participants
@galak @aescolar