Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing 'label' on most nodes with 'compatible = "pwm-leds"' #17665

Closed
ulfalizer opened this issue Jul 19, 2019 · 2 comments · Fixed by #17713
Closed

Missing 'label' on most nodes with 'compatible = "pwm-leds"' #17665

ulfalizer opened this issue Jul 19, 2019 · 2 comments · Fixed by #17713
Assignees
Labels
area: Devicetree bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@ulfalizer
Copy link
Collaborator

dts/bindings/led/pwm-leds.yaml says that any node with that binding must have a label property, but only a few nodes with compatible = "pwm-leds" have a label property.

List for reference:

$ git grep pwm-leds
boards/arm/hexiwear_k64/hexiwear_k64.dts:               compatible = "pwm-leds";
boards/arm/nucleo_l496zg/nucleo_l496zg.dts:             compatible = "pwm-leds";
boards/riscv32/hifive1/hifive1.dts:             compatible = "pwm-leds";
dts/bindings/device_node.yaml.template:# Here's an example for a pwm-leds binding in which the child nodes
dts/bindings/led/pwm-leds.yaml:      constraint: "pwm-leds"

This leads to failures in #17660, which turns missing category: required properties into an error.

Not familiar enough with how this is used to know what the proper solution is. A quickfix would be to make label optional instead in the binding (category: optional).

@ulfalizer ulfalizer added the bug The issue is a bug, or the PR is fixing a bug label Jul 19, 2019
@ulfalizer
Copy link
Collaborator Author

CC @galak

@ioannisg ioannisg added priority: low Low impact/importance bug and removed priority: low Low impact/importance bug labels Jul 19, 2019
@ulfalizer
Copy link
Collaborator Author

@ioannisg
Note that these are part of fixing an entire class of issue, so don't get hung up on the individual fixes. It'd be nice to get them all fixed soonish, even if each one is low-prio in itself.

galak added a commit to galak/zephyr that referenced this issue Jul 22, 2019
The label property in the pwm-leds sub-node is optional, so mark it as
such.

Fixes: zephyrproject-rtos#17665

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
galak added a commit that referenced this issue Jul 23, 2019
The label property in the pwm-leds sub-node is optional, so mark it as
such.

Fixes: #17665

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
LeiW000 pushed a commit to LeiW000/zephyr that referenced this issue Sep 2, 2019
The label property in the pwm-leds sub-node is optional, so mark it as
such.

Fixes: zephyrproject-rtos#17665

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Devicetree bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants