Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync submodules by default #499

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Sync submodules by default #499

merged 1 commit into from
Apr 20, 2021

Conversation

mbolivar-nordic
Copy link
Contributor

@mbolivar-nordic mbolivar-nordic commented Apr 12, 2021 •
edited
Loading

Fixes: #497

@mbolivar-nordic mbolivar-nordic mentioned this pull request Apr 12, 2021
Closed
Damian-Nordic
Damian-Nordic approved these changes Apr 13, 2021
View reviewed changes
Copy link

@Damian-Nordic Damian-Nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed only the last commit. Also, I tested it on our Project CHIP case and west update was able to correctly update the submodule location. Thanks for the change!

@mbolivar-nordic
update: synchronize submodules by default
f450cef 
This will keep the URL of each submodule up to date if they change.

Allow users to get the old behavior via a new update.sync-submodules
config option, which defaults to True but can be set to False.

Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
@mbolivar-nordic
Copy link
Contributor Author

Thanks @Damian-Nordic. Rebased and ready for review.

@mbolivar-nordic
Copy link
Contributor Author

I'm just going to merge this

@mbolivar-nordic mbolivar-nordic merged commit e02ac52 into zephyrproject-rtos:master Apr 20, 2021
@marc-hb marc-hb added the git submodules The enemy! label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@marc-hb marc-hb Awaiting requested review from marc-hb

@carlescufi carlescufi Awaiting requested review from carlescufi

@tejlmand tejlmand Awaiting requested review from tejlmand

Assignees
No one assigned
Labels
git submodules The enemy!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

west update doesn't sync submodule location
3 participants
@mbolivar-nordic @Damian-Nordic @marc-hb