Update zephyr to thrift 0.20.0 #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client: netstd Patch: Jens Geyer
This reverts commit b39370e, and also adds a test case for THRIFT-5685.
Client: Java Patch: Thomas Lorblanchès This closes apache#2761
MSVC warning C4706: assignment within conditional expression
Client: Java Patch: Thomas Lorblanchès This closes apache#2761
Client: Delphi Patch: Jens Geyer
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.0.0-20210510120138-977fb7262007 to 0.1.0. - [Release notes](https://github.com/golang/sys/releases) - [Commits](https://github.com/golang/sys/commits/v0.1.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
This reverts commit b39370e, and also adds a test case for THRIFT-5685.
It stated Java 8 but now we are on Java 11
Client: haxe Patch: Jens Geyer
This replaces and closes apache#2774.
* update gradle to version 7.6 * update hash
Client: netstd Patch: Jens Geyer This closes apache#2965
Client: netstd Patch: Jens Geyer
Client: Delphi Patch: Jens Geyer plus a minor netstd fix
Client: go TBinaryProtocol and TCompactProtocol (and as an extension, THeaderProtocol) use TRichTransport's ReadByte/WriteByte functions a lot under the hood, and in some extreme cases those ReadByte/WriteByte calls can generate a lot of allocations for the byte they used. Use a resource pool to help reduce the allocations.
This reverts commit 344498b. In our extreme case this actually made things worse. On 30s cpu profiles, although mallocgc reduced from 27.13s to 26.30s, the byte pool itself costed 11.9s. Looking at writeByte and readByte, writeByte increased from 3.69s to 5.89s, and readByte increased from 11.36s to 16.09s.
Client: netstd Patch: Jens Geyer
Client: Delphi Patch: Jens Geyer FIX: end-of-line comments may cause uncompileable code
Client: go Fix 2 instances we are using == to check on error but should have used errors.Is instead.
Client: go While I'm here, also auto add compression transforms read (currently only zlib is supported) to writeTransforms so that a server will auto use the same compression on the responses as the client chose to use in the requests.
…ssue at deprecated enums Client: netstd Patch: Jens Geyer
This is a "trivial" change for go compiler to always use the combination of indent_up, indent_down, and indent, over manual indentation (by adding 2 spaces at the beginning of the string). Also change go compiler's indent_str to tab over 2 spaces. While I'm here, also made a few minor tweaks on generated go code.
Client: netstd Patch: Steven Mitcham This closes apache#2979
Client: delphi Patch: Jens Geyer
Client: Delphi Patch: Jens Geyer
Client: delphi Patch: Jens Geyer Follow-up: fix memory leak
Client: go This should got most of them. Also fixed an indentation bug from 4930ca.
Client: php Patch: Ilya Urvachev & Volodymyr Panivko This closes apache#2983
Bumps [org.jetbrains.kotlinx:kotlinx-coroutines-jdk8](https://github.com/Kotlin/kotlinx.coroutines) from 1.8.0 to 1.8.1. - [Release notes](https://github.com/Kotlin/kotlinx.coroutines/releases) - [Changelog](https://github.com/Kotlin/kotlinx.coroutines/blob/master/CHANGES.md) - [Commits](Kotlin/kotlinx.coroutines@1.8.0...1.8.1) --- updated-dependencies: - dependency-name: org.jetbrains.kotlinx:kotlinx-coroutines-jdk8 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
This updates the compact protocol documentation to simplify the explanation of Zigzag and ULEB128 encoding, along with links to wikipedia. In addition it uses varing instead of var int since the former is more common.
This fixes a small case I missed in 4930cac. Before: func NewFoo() *Foo { return &Foo{ DefDef: 10, DefOpt: 11, } } After: func NewFoo() *Foo { return &Foo{ DefDef: 10, DefOpt: 11, } }
When enabled zlib in THeaderTransport we observed very high cpu overhead, use a pool for zlib writers to improve efficiency.
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Client: cpp/CMakeLists.txt Patch: Carel Combrink This closes apache#2958
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ws](https://github.com/websockets/ws) from 6.2.2 to 6.2.3. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@6.2.2...6.2.3) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Temporarily add a basic `zephyr/module.yaml` entry to enable integration with Zephyr's build system. Zephyr module integration will be done in the main Zephyr tree. This change itself should eventually go upstream and the preference for this project would be to have all changes go upstream first. So in a sense, the fork of `apache/thrift` to `zephyrproject-rtos/thrift` should be kept as redundant as possible so that it could be replaced with the upstream project at any time. Signed-off-by: Chris Friedt <cfriedt@meta.com>
This was referenced Jun 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebase the current
zephyrbranch onto https://github.com/apache/thrift/releases/tag/v0.20.0