#2374 - Extract common parts from condition

zephir-lang · Aug 22, 2022 · e57e2f2 · e57e2f2
1 parent 27b663c
commit e57e2f2
Showing 1 changed file with 7 additions and 14 deletions.
diff --git a/Library/ClassMethod.php b/Library/ClassMethod.php
@@ -2229,24 +2229,17 @@ public function hasChildReturnStatementType(array $statement): bool
             }
 
             $statements = $statement['else_statements'];
-            foreach ($statements as $item) {
-                $type = $item['type'] ?? null;
-                if ('return' === $type || 'throw' === $type) {
-                    return true;
-                }
-
-                return $this->hasChildReturnStatementType($item);
-            }
         } else {
             $statements = $statement['statements'];
-            foreach ($statements as $item) {
-                $type = $item['type'] ?? null;
-                if ('return' === $type || 'throw' === $type) {
-                    return true;
-                }
+        }
 
-                return $this->hasChildReturnStatementType($item);
+        foreach ($statements as $item) {
+            $type = $item['type'] ?? null;
+            if ('return' === $type || 'throw' === $type) {
+                return true;
             }
+
+            return $this->hasChildReturnStatementType($item);
         }
 
         return false;