refactor: better deprecations #541

nikophil · 2023-12-21T10:54:12Z

This PRs fixes few things:

remove deprecations.php file
follow https://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cf where it seems to work (as he says, it's a "best effort" thing, there is no perfect solution)
remove all sprintf() used along with trigger_deprecation() I think this will decrease the amount of deprecation is user land by a lot

src/Persistence/Proxy.php

kbond

Just reviewed the first bit of the upgrade doc for now. I'll get to the rest later.

UPGRADE-2.0.md

nikophil · 2023-12-29T14:01:57Z

UPGRADE-2.0.md

I have still added nothing about rector, I'm waiting to know how we will ship the rector rules

refactor: Foundry 2 BC layer refactor: deprecate ModelFactory refactor: deprecate ModelFactory::getDefaults() refactor: deprecate ModelFactory::getClass() refactor: add #[\ReturnTypeWillChange] to PersistentProxyObjectFactory::initialize() refactor: deprecate proxy class refactor: deprecate stuff in functions.php refactor: deprecate RepositoryProxy refactor: deprecate stuff in Instantiator bot: fix cs [skip ci] minor: deprecate more stuff * refactor: deprecate passing callable to sequence * refactor: deprecate usage of disable/enable_persisting without doctrine * refactor: deprecate TestState for UnitTestConfig bot: fix cs [skip ci] refactor: introduce PersistentObjectFactory and deprecate PersistentProxyObjectFactory with final (#518) * refactor: introduce PersistentObjectFactory and deprecate PersistentProxyObjectFactory with final * refactor: introduce persistent_factory() bot: fix cs [skip ci] refactor: deprecate config database_resetter (#523) * refactor: deprecate config database_resetter.orm in favor of orm.reset * refactor: deprecate config database_resetter.odm in favor of mongo.reset bot: fix cs [skip ci] refactor: deprecate config instantiator.without_constructor (#522) bot: fix cs [skip ci] refactor: add BC layer for methods in Instantiator (#535) refactor: change phpstan FactoryCollection return type (#530) bot: fix cs [skip ci] refactor: remove not working BC layer on Factory::__construct() (#529) refactor(bc layer): introduce Proxy interface (#528) bot: fix cs [skip ci] refactor: deprecate config auto_refresh_proxies (#524) bot: fix cs [skip ci] refactor: better deprecations (#541) bot: sync with template [skip ci] bot: fix cs [skip ci] feat: introduce ObjectFactory (#543) bot: fix cs [skip ci] feat: introduce rector rules 🎉 (#544) refactor: create ObjectFactory with make:factory --no-persistence (#546) refactor: more deprecations (#547) * refactor: deprecate Factory::faker() outisde of a factory * refactor: deprecate FactoryCollection::set() bot: fix cs [skip ci] fix: remove directory utils/rector/vendor from git fix: rename Proxy::get() into Proxy::forceGet() fix: rollback BC layer on sequence() attributes fix(rector): handle extending user-defined factory class fix(rector): proxify create() and instantiate() transformation (#549) fix(rector): don't remove ->object() call for create() or instantiate() refctor: deprecate FactoryCollection::factory() (#550) refactor: deprecate using proxy with anonymous class bot: fix cs [skip ci] docs(bc layer): document known BC breaks (#554) refactor: deprecate $orderBy argument in RepositoryDecorator::findOneBy() (#551) fix(rector): bump rector/rector 1.0

refactor: Foundry 2 BC layer refactor: deprecate ModelFactory refactor: deprecate ModelFactory::getDefaults() refactor: deprecate ModelFactory::getClass() refactor: add #[\ReturnTypeWillChange] to PersistentProxyObjectFactory::initialize() refactor: deprecate proxy class refactor: deprecate stuff in functions.php refactor: deprecate RepositoryProxy refactor: deprecate stuff in Instantiator bot: fix cs [skip ci] minor: deprecate more stuff * refactor: deprecate passing callable to sequence * refactor: deprecate usage of disable/enable_persisting without doctrine * refactor: deprecate TestState for UnitTestConfig bot: fix cs [skip ci] refactor: introduce PersistentObjectFactory and deprecate PersistentProxyObjectFactory with final (#518) * refactor: introduce PersistentObjectFactory and deprecate PersistentProxyObjectFactory with final * refactor: introduce persistent_factory() bot: fix cs [skip ci] refactor: deprecate config database_resetter (#523) * refactor: deprecate config database_resetter.orm in favor of orm.reset * refactor: deprecate config database_resetter.odm in favor of mongo.reset bot: fix cs [skip ci] refactor: deprecate config instantiator.without_constructor (#522) bot: fix cs [skip ci] refactor: add BC layer for methods in Instantiator (#535) refactor: change phpstan FactoryCollection return type (#530) bot: fix cs [skip ci] refactor: remove not working BC layer on Factory::__construct() (#529) refactor(bc layer): introduce Proxy interface (#528) bot: fix cs [skip ci] refactor: deprecate config auto_refresh_proxies (#524) bot: fix cs [skip ci] refactor: better deprecations (#541) bot: sync with template [skip ci] bot: fix cs [skip ci] feat: introduce ObjectFactory (#543) bot: fix cs [skip ci] feat: introduce rector rules 🎉 (#544) refactor: create ObjectFactory with make:factory --no-persistence (#546) refactor: more deprecations (#547) * refactor: deprecate Factory::faker() outisde of a factory * refactor: deprecate FactoryCollection::set() bot: fix cs [skip ci] fix: remove directory utils/rector/vendor from git fix: rename Proxy::get() into Proxy::forceGet() fix: rollback BC layer on sequence() attributes fix(rector): handle extending user-defined factory class fix(rector): proxify create() and instantiate() transformation (#549) fix(rector): don't remove ->object() call for create() or instantiate() refctor: deprecate FactoryCollection::factory() (#550) refactor: deprecate using proxy with anonymous class bot: fix cs [skip ci] docs(bc layer): document known BC breaks (#554) refactor: deprecate $orderBy argument in RepositoryDecorator::findOneBy() (#551) fix(rector): bump rector/rector 1.0 fix(bc layer): install php cs fixer for maker bundle (#560)

@method

refactor: Foundry 2 BC layer refactor: deprecate ModelFactory refactor: deprecate ModelFactory::getDefaults() refactor: deprecate ModelFactory::getClass() refactor: add #[\ReturnTypeWillChange] to PersistentProxyObjectFactory::initialize() refactor: deprecate proxy class refactor: deprecate stuff in functions.php refactor: deprecate RepositoryProxy refactor: deprecate stuff in Instantiator bot: fix cs [skip ci] minor: deprecate more stuff * refactor: deprecate passing callable to sequence * refactor: deprecate usage of disable/enable_persisting without doctrine * refactor: deprecate TestState for UnitTestConfig bot: fix cs [skip ci] refactor: introduce PersistentObjectFactory and deprecate PersistentProxyObjectFactory with final (#518) * refactor: introduce PersistentObjectFactory and deprecate PersistentProxyObjectFactory with final * refactor: introduce persistent_factory() bot: fix cs [skip ci] refactor: deprecate config database_resetter (#523) * refactor: deprecate config database_resetter.orm in favor of orm.reset * refactor: deprecate config database_resetter.odm in favor of mongo.reset bot: fix cs [skip ci] refactor: deprecate config instantiator.without_constructor (#522) bot: fix cs [skip ci] refactor: add BC layer for methods in Instantiator (#535) refactor: change phpstan FactoryCollection return type (#530) bot: fix cs [skip ci] refactor: remove not working BC layer on Factory::__construct() (#529) refactor(bc layer): introduce Proxy interface (#528) bot: fix cs [skip ci] refactor: deprecate config auto_refresh_proxies (#524) bot: fix cs [skip ci] refactor: better deprecations (#541) bot: sync with template [skip ci] bot: fix cs [skip ci] feat: introduce ObjectFactory (#543) bot: fix cs [skip ci] feat: introduce rector rules 🎉 (#544) refactor: create ObjectFactory with make:factory --no-persistence (#546) refactor: more deprecations (#547) * refactor: deprecate Factory::faker() outisde of a factory * refactor: deprecate FactoryCollection::set() bot: fix cs [skip ci] fix: remove directory utils/rector/vendor from git fix: rename Proxy::get() into Proxy::forceGet() fix: rollback BC layer on sequence() attributes fix(rector): handle extending user-defined factory class fix(rector): proxify create() and instantiate() transformation (#549) fix(rector): don't remove ->object() call for create() or instantiate() refctor: deprecate FactoryCollection::factory() (#550) refactor: deprecate using proxy with anonymous class bot: fix cs [skip ci] docs(bc layer): document known BC breaks (#554) refactor: deprecate $orderBy argument in RepositoryDecorator::findOneBy() (#551) fix(rector): bump rector/rector 1.0 fix(bc layer): install php cs fixer for maker bundle (#560) refactor(bc layer): deprecate passing states as string to Factory::new() (#559) bot: fix cs [skip ci] minor: fix some types for sca rector: remove un-needed Factory<Proxy<>> php docs rector: migrate old proxy phpdoc to generic ones rector: use getName() instead of cast to string nodes rector: fix @method parameters rendering bc: deprecate config auto_refresh_proxies bc: introduce ProxyRepositoryDecorator bot: fix cs [skip ci] fix(proxy): assert object is not scheduled for insert before throwing in _refresh minor(rector): change doc to comply to rector 1.0 bc: throw deprecation when calling Configuration::disableDefaultProxyAutoRefresh() bot: fix cs [skip ci] bc: throw deprecation when calling Configuration::disableDefaultProxyAutoRefresh() bc: add repo class in ProxyRepositoryDecorator @methods in rector + maker bot: fix cs [skip ci] bc: fix Proxy sca problem in ModelFactory bot: fix cs [skip ci] bc: fix Proxy sca problem in ModelFactory bot: fix cs [skip ci] bc: fix PersistentObjectFactory @methods fix(bc): add missing import bc(rector): remove useless "unproxify" array_map bc(rector): fix factories @method phpdoc bc(rector): clean rector bot: fix cs [skip ci]

@method

refactor: Foundry 2 BC layer refactor: deprecate ModelFactory refactor: deprecate ModelFactory::getDefaults() refactor: deprecate ModelFactory::getClass() refactor: add #[\ReturnTypeWillChange] to PersistentProxyObjectFactory::initialize() refactor: deprecate proxy class refactor: deprecate stuff in functions.php refactor: deprecate RepositoryProxy refactor: deprecate stuff in Instantiator bot: fix cs [skip ci] minor: deprecate more stuff * refactor: deprecate passing callable to sequence * refactor: deprecate usage of disable/enable_persisting without doctrine * refactor: deprecate TestState for UnitTestConfig bot: fix cs [skip ci] refactor: introduce PersistentObjectFactory and deprecate PersistentProxyObjectFactory with final (#518) * refactor: introduce PersistentObjectFactory and deprecate PersistentProxyObjectFactory with final * refactor: introduce persistent_factory() bot: fix cs [skip ci] refactor: deprecate config database_resetter (#523) * refactor: deprecate config database_resetter.orm in favor of orm.reset * refactor: deprecate config database_resetter.odm in favor of mongo.reset bot: fix cs [skip ci] refactor: deprecate config instantiator.without_constructor (#522) bot: fix cs [skip ci] refactor: add BC layer for methods in Instantiator (#535) refactor: change phpstan FactoryCollection return type (#530) bot: fix cs [skip ci] refactor: remove not working BC layer on Factory::__construct() (#529) refactor(bc layer): introduce Proxy interface (#528) bot: fix cs [skip ci] refactor: deprecate config auto_refresh_proxies (#524) bot: fix cs [skip ci] refactor: better deprecations (#541) bot: sync with template [skip ci] bot: fix cs [skip ci] feat: introduce ObjectFactory (#543) bot: fix cs [skip ci] feat: introduce rector rules 🎉 (#544) refactor: create ObjectFactory with make:factory --no-persistence (#546) refactor: more deprecations (#547) * refactor: deprecate Factory::faker() outisde of a factory * refactor: deprecate FactoryCollection::set() bot: fix cs [skip ci] fix: remove directory utils/rector/vendor from git fix: rename Proxy::get() into Proxy::forceGet() fix: rollback BC layer on sequence() attributes fix(rector): handle extending user-defined factory class fix(rector): proxify create() and instantiate() transformation (#549) fix(rector): don't remove ->object() call for create() or instantiate() refctor: deprecate FactoryCollection::factory() (#550) refactor: deprecate using proxy with anonymous class bot: fix cs [skip ci] docs(bc layer): document known BC breaks (#554) refactor: deprecate $orderBy argument in RepositoryDecorator::findOneBy() (#551) fix(rector): bump rector/rector 1.0 fix(bc layer): install php cs fixer for maker bundle (#560) refactor(bc layer): deprecate passing states as string to Factory::new() (#559) bot: fix cs [skip ci] minor: fix some types for sca rector: remove un-needed Factory<Proxy<>> php docs rector: migrate old proxy phpdoc to generic ones rector: use getName() instead of cast to string nodes rector: fix @method parameters rendering bc: deprecate config auto_refresh_proxies bc: introduce ProxyRepositoryDecorator bot: fix cs [skip ci] fix(proxy): assert object is not scheduled for insert before throwing in _refresh minor(rector): change doc to comply to rector 1.0 bc: throw deprecation when calling Configuration::disableDefaultProxyAutoRefresh() bot: fix cs [skip ci] bc: throw deprecation when calling Configuration::disableDefaultProxyAutoRefresh() bc: add repo class in ProxyRepositoryDecorator @methods in rector + maker bot: fix cs [skip ci] bc: fix Proxy sca problem in ModelFactory bot: fix cs [skip ci] bc: fix Proxy sca problem in ModelFactory bot: fix cs [skip ci] bc: fix PersistentObjectFactory @methods fix(bc): add missing import bc(rector): remove useless "unproxify" array_map bc(rector): fix factories @method phpdoc bc(rector): clean rector bot: fix cs [skip ci]

@method

refactor: Foundry 2 BC layer refactor: deprecate ModelFactory refactor: deprecate ModelFactory::getDefaults() refactor: deprecate ModelFactory::getClass() refactor: add #[\ReturnTypeWillChange] to PersistentProxyObjectFactory::initialize() refactor: deprecate proxy class refactor: deprecate stuff in functions.php refactor: deprecate RepositoryProxy refactor: deprecate stuff in Instantiator bot: fix cs [skip ci] minor: deprecate more stuff * refactor: deprecate passing callable to sequence * refactor: deprecate usage of disable/enable_persisting without doctrine * refactor: deprecate TestState for UnitTestConfig bot: fix cs [skip ci] refactor: introduce PersistentObjectFactory and deprecate PersistentProxyObjectFactory with final (#518) * refactor: introduce PersistentObjectFactory and deprecate PersistentProxyObjectFactory with final * refactor: introduce persistent_factory() bot: fix cs [skip ci] refactor: deprecate config database_resetter (#523) * refactor: deprecate config database_resetter.orm in favor of orm.reset * refactor: deprecate config database_resetter.odm in favor of mongo.reset bot: fix cs [skip ci] refactor: deprecate config instantiator.without_constructor (#522) bot: fix cs [skip ci] refactor: add BC layer for methods in Instantiator (#535) refactor: change phpstan FactoryCollection return type (#530) bot: fix cs [skip ci] refactor: remove not working BC layer on Factory::__construct() (#529) refactor(bc layer): introduce Proxy interface (#528) bot: fix cs [skip ci] refactor: deprecate config auto_refresh_proxies (#524) bot: fix cs [skip ci] refactor: better deprecations (#541) bot: sync with template [skip ci] bot: fix cs [skip ci] feat: introduce ObjectFactory (#543) bot: fix cs [skip ci] feat: introduce rector rules 🎉 (#544) refactor: create ObjectFactory with make:factory --no-persistence (#546) refactor: more deprecations (#547) * refactor: deprecate Factory::faker() outisde of a factory * refactor: deprecate FactoryCollection::set() bot: fix cs [skip ci] fix: remove directory utils/rector/vendor from git fix: rename Proxy::get() into Proxy::forceGet() fix: rollback BC layer on sequence() attributes fix(rector): handle extending user-defined factory class fix(rector): proxify create() and instantiate() transformation (#549) fix(rector): don't remove ->object() call for create() or instantiate() refctor: deprecate FactoryCollection::factory() (#550) refactor: deprecate using proxy with anonymous class bot: fix cs [skip ci] docs(bc layer): document known BC breaks (#554) refactor: deprecate $orderBy argument in RepositoryDecorator::findOneBy() (#551) fix(rector): bump rector/rector 1.0 fix(bc layer): install php cs fixer for maker bundle (#560) refactor(bc layer): deprecate passing states as string to Factory::new() (#559) bot: fix cs [skip ci] minor: fix some types for sca rector: remove un-needed Factory<Proxy<>> php docs rector: migrate old proxy phpdoc to generic ones rector: use getName() instead of cast to string nodes rector: fix @method parameters rendering bc: deprecate config auto_refresh_proxies bc: introduce ProxyRepositoryDecorator bot: fix cs [skip ci] fix(proxy): assert object is not scheduled for insert before throwing in _refresh minor(rector): change doc to comply to rector 1.0 bc: throw deprecation when calling Configuration::disableDefaultProxyAutoRefresh() bot: fix cs [skip ci] bc: throw deprecation when calling Configuration::disableDefaultProxyAutoRefresh() bc: add repo class in ProxyRepositoryDecorator @methods in rector + maker bot: fix cs [skip ci] bc: fix Proxy sca problem in ModelFactory bot: fix cs [skip ci] bc: fix Proxy sca problem in ModelFactory bot: fix cs [skip ci] bc: fix PersistentObjectFactory @methods fix(bc): add missing import bc(rector): remove useless "unproxify" array_map bc(rector): fix factories @method phpdoc bc(rector): clean rector bot: fix cs [skip ci]

@method

refactor: Foundry 2 BC layer refactor: deprecate ModelFactory refactor: deprecate ModelFactory::getDefaults() refactor: deprecate ModelFactory::getClass() refactor: add #[\ReturnTypeWillChange] to PersistentProxyObjectFactory::initialize() refactor: deprecate proxy class refactor: deprecate stuff in functions.php refactor: deprecate RepositoryProxy refactor: deprecate stuff in Instantiator bot: fix cs [skip ci] minor: deprecate more stuff * refactor: deprecate passing callable to sequence * refactor: deprecate usage of disable/enable_persisting without doctrine * refactor: deprecate TestState for UnitTestConfig bot: fix cs [skip ci] refactor: introduce PersistentObjectFactory and deprecate PersistentProxyObjectFactory with final (#518) * refactor: introduce PersistentObjectFactory and deprecate PersistentProxyObjectFactory with final * refactor: introduce persistent_factory() bot: fix cs [skip ci] refactor: deprecate config database_resetter (#523) * refactor: deprecate config database_resetter.orm in favor of orm.reset * refactor: deprecate config database_resetter.odm in favor of mongo.reset bot: fix cs [skip ci] refactor: deprecate config instantiator.without_constructor (#522) bot: fix cs [skip ci] refactor: add BC layer for methods in Instantiator (#535) refactor: change phpstan FactoryCollection return type (#530) bot: fix cs [skip ci] refactor: remove not working BC layer on Factory::__construct() (#529) refactor(bc layer): introduce Proxy interface (#528) bot: fix cs [skip ci] refactor: deprecate config auto_refresh_proxies (#524) bot: fix cs [skip ci] refactor: better deprecations (#541) bot: sync with template [skip ci] bot: fix cs [skip ci] feat: introduce ObjectFactory (#543) bot: fix cs [skip ci] feat: introduce rector rules 🎉 (#544) refactor: create ObjectFactory with make:factory --no-persistence (#546) refactor: more deprecations (#547) * refactor: deprecate Factory::faker() outisde of a factory * refactor: deprecate FactoryCollection::set() bot: fix cs [skip ci] fix: remove directory utils/rector/vendor from git fix: rename Proxy::get() into Proxy::forceGet() fix: rollback BC layer on sequence() attributes fix(rector): handle extending user-defined factory class fix(rector): proxify create() and instantiate() transformation (#549) fix(rector): don't remove ->object() call for create() or instantiate() refctor: deprecate FactoryCollection::factory() (#550) refactor: deprecate using proxy with anonymous class bot: fix cs [skip ci] docs(bc layer): document known BC breaks (#554) refactor: deprecate $orderBy argument in RepositoryDecorator::findOneBy() (#551) fix(rector): bump rector/rector 1.0 fix(bc layer): install php cs fixer for maker bundle (#560) refactor(bc layer): deprecate passing states as string to Factory::new() (#559) bot: fix cs [skip ci] minor: fix some types for sca rector: remove un-needed Factory<Proxy<>> php docs rector: migrate old proxy phpdoc to generic ones rector: use getName() instead of cast to string nodes rector: fix @method parameters rendering bc: deprecate config auto_refresh_proxies bc: introduce ProxyRepositoryDecorator bot: fix cs [skip ci] fix(proxy): assert object is not scheduled for insert before throwing in _refresh minor(rector): change doc to comply to rector 1.0 bc: throw deprecation when calling Configuration::disableDefaultProxyAutoRefresh() bot: fix cs [skip ci] bc: throw deprecation when calling Configuration::disableDefaultProxyAutoRefresh() bc: add repo class in ProxyRepositoryDecorator @methods in rector + maker bot: fix cs [skip ci] bc: fix Proxy sca problem in ModelFactory bot: fix cs [skip ci] bc: fix Proxy sca problem in ModelFactory bot: fix cs [skip ci] bc: fix PersistentObjectFactory @methods fix(bc): add missing import bc(rector): remove useless "unproxify" array_map bc(rector): fix factories @method phpdoc bc(rector): clean rector bot: fix cs [skip ci]

@method

* refactor: Foundry 2 BC layer refactor: Foundry 2 BC layer refactor: deprecate ModelFactory refactor: deprecate ModelFactory::getDefaults() refactor: deprecate ModelFactory::getClass() refactor: add #[\ReturnTypeWillChange] to PersistentProxyObjectFactory::initialize() refactor: deprecate proxy class refactor: deprecate stuff in functions.php refactor: deprecate RepositoryProxy refactor: deprecate stuff in Instantiator bot: fix cs [skip ci] minor: deprecate more stuff * refactor: deprecate passing callable to sequence * refactor: deprecate usage of disable/enable_persisting without doctrine * refactor: deprecate TestState for UnitTestConfig bot: fix cs [skip ci] refactor: introduce PersistentObjectFactory and deprecate PersistentProxyObjectFactory with final (#518) * refactor: introduce PersistentObjectFactory and deprecate PersistentProxyObjectFactory with final * refactor: introduce persistent_factory() bot: fix cs [skip ci] refactor: deprecate config database_resetter (#523) * refactor: deprecate config database_resetter.orm in favor of orm.reset * refactor: deprecate config database_resetter.odm in favor of mongo.reset bot: fix cs [skip ci] refactor: deprecate config instantiator.without_constructor (#522) bot: fix cs [skip ci] refactor: add BC layer for methods in Instantiator (#535) refactor: change phpstan FactoryCollection return type (#530) bot: fix cs [skip ci] refactor: remove not working BC layer on Factory::__construct() (#529) refactor(bc layer): introduce Proxy interface (#528) bot: fix cs [skip ci] refactor: deprecate config auto_refresh_proxies (#524) bot: fix cs [skip ci] refactor: better deprecations (#541) bot: sync with template [skip ci] bot: fix cs [skip ci] feat: introduce ObjectFactory (#543) bot: fix cs [skip ci] feat: introduce rector rules 🎉 (#544) refactor: create ObjectFactory with make:factory --no-persistence (#546) refactor: more deprecations (#547) * refactor: deprecate Factory::faker() outisde of a factory * refactor: deprecate FactoryCollection::set() bot: fix cs [skip ci] fix: remove directory utils/rector/vendor from git fix: rename Proxy::get() into Proxy::forceGet() fix: rollback BC layer on sequence() attributes fix(rector): handle extending user-defined factory class fix(rector): proxify create() and instantiate() transformation (#549) fix(rector): don't remove ->object() call for create() or instantiate() refctor: deprecate FactoryCollection::factory() (#550) refactor: deprecate using proxy with anonymous class bot: fix cs [skip ci] docs(bc layer): document known BC breaks (#554) refactor: deprecate $orderBy argument in RepositoryDecorator::findOneBy() (#551) fix(rector): bump rector/rector 1.0 fix(bc layer): install php cs fixer for maker bundle (#560) refactor(bc layer): deprecate passing states as string to Factory::new() (#559) bot: fix cs [skip ci] minor: fix some types for sca rector: remove un-needed Factory<Proxy<>> php docs rector: migrate old proxy phpdoc to generic ones rector: use getName() instead of cast to string nodes rector: fix @method parameters rendering bc: deprecate config auto_refresh_proxies bc: introduce ProxyRepositoryDecorator bot: fix cs [skip ci] fix(proxy): assert object is not scheduled for insert before throwing in _refresh minor(rector): change doc to comply to rector 1.0 bc: throw deprecation when calling Configuration::disableDefaultProxyAutoRefresh() bot: fix cs [skip ci] bc: throw deprecation when calling Configuration::disableDefaultProxyAutoRefresh() bc: add repo class in ProxyRepositoryDecorator @methods in rector + maker bot: fix cs [skip ci] bc: fix Proxy sca problem in ModelFactory bot: fix cs [skip ci] bc: fix Proxy sca problem in ModelFactory bot: fix cs [skip ci] bc: fix PersistentObjectFactory @methods fix(bc): add missing import bc(rector): remove useless "unproxify" array_map bc(rector): fix factories @method phpdoc bc(rector): clean rector bot: fix cs [skip ci] * rector: rewrite phpdoc (#571) * fix(rector): repository method is static * fix(rector) second argument for many() is optional

nikophil force-pushed the 1.x-bc-layer/fix-deprecations branch 3 times, most recently from be7b9f9 to 7546a3e Compare December 21, 2023 13:00

nikophil changed the title ~~1.x bc layer/fix deprecations~~ refactor: better deprecations Dec 21, 2023

nikophil commented Dec 21, 2023

View reviewed changes

src/Persistence/Proxy.php Show resolved Hide resolved

nikophil force-pushed the 1.x-bc-layer/fix-deprecations branch 6 times, most recently from ffb2f69 to 776d88a Compare December 21, 2023 16:08

kbond reviewed Dec 22, 2023

View reviewed changes

UPGRADE-2.0.md Outdated Show resolved Hide resolved

UPGRADE-2.0.md Outdated Show resolved Hide resolved

UPGRADE-2.0.md Outdated Show resolved Hide resolved

nikophil force-pushed the 1.x-bc-layer/fix-deprecations branch 2 times, most recently from 839d985 to 07cd408 Compare December 29, 2023 14:01

nikophil commented Dec 29, 2023

View reviewed changes

UPGRADE-2.0.md

Copy link

Member Author

nikophil Dec 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have still added nothing about rector, I'm waiting to know how we will ship the rector rules

nikophil force-pushed the 1.x-bc-layer/fix-deprecations branch from 07cd408 to 892ac53 Compare December 29, 2023 14:05

refactor: fix last deprecations

0d3c353

nikophil force-pushed the 1.x-bc-layer/fix-deprecations branch from 892ac53 to 0d3c353 Compare January 7, 2024 11:47

nikophil merged commit 656e9e1 into zenstruck:1.x-bc Jan 7, 2024
21 checks passed

nikophil deleted the 1.x-bc-layer/fix-deprecations branch January 7, 2024 11:49

nikophil added a commit that referenced this pull request Jan 7, 2024

refactor: better deprecations (#541)

91ac303

nikophil mentioned this pull request Jan 7, 2024

refactor: create ObjectFactory with make:factory --no-persistence #546

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: better deprecations #541

refactor: better deprecations #541

nikophil commented Dec 21, 2023 •

edited

Loading

kbond left a comment

nikophil Dec 29, 2023

refactor: better deprecations #541

refactor: better deprecations #541

Conversation

nikophil commented Dec 21, 2023 • edited Loading

kbond left a comment

Choose a reason for hiding this comment

nikophil Dec 29, 2023

Choose a reason for hiding this comment

nikophil commented Dec 21, 2023 •

edited

Loading