refactor: remove not working BC layer on Factory::__construct() (#529)

src/AnonymousFactory.php

@@ -36,7 +36,7 @@ public function __construct(string $class, array|callable $defaultAttributes = [
 
         trigger_deprecation('zenstruck\foundry', '1.30', 'Class "AnonymousFactory" is deprecated and will be removed in 2.0. Use the "anonymous()" or "repository()" functions instead.');
 
-        parent::__construct($class, $defaultAttributes, calledInternally: true);
+        parent::__construct($class, $defaultAttributes);
     }
 
     /**

src/Factory.php

@@ -58,17 +58,13 @@ class Factory
     /**
      * @param class-string<TObject> $class
      */
-    public function __construct(string $class, array|callable $defaultAttributes = [], bool $calledInternally = false)
+    public function __construct(string $class, array|callable $defaultAttributes = [])
     {
         /** @phpstan-ignore-next-line */
         if (self::class === static::class) {
             trigger_deprecation('zenstruck/foundry', '1.9', 'Instantiating "%s" directly is deprecated and this class will be abstract in 2.0, use "anonymous()" function instead.', self::class);
         }
 
-        if (!$calledInternally) {
-            trigger_deprecation('zenstruck\foundry', '1.37.0', 'Constructor of class Zenstruck\Foundry\Factory is deprecated and will be removed in version 2.0. You should not call parent::__construct() anymore from your factories.');
-        }
-
         $this->class = $class;
         $this->attributes[] = $defaultAttributes;
     }

src/Persistence/PersistentObjectFactory.php

@@ -29,7 +29,7 @@ abstract class PersistentObjectFactory extends Factory
 {
     public function __construct()
     {
-        parent::__construct(static::class(), calledInternally: true);
+        parent::__construct(static::class());
     }
 
     /**