Add stack delete
confirmation prompt
#548
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe changes
I added a confirmation check prior to stack deletion. You can do a 'force' delete (i.e. without confirmation) by passing in a
-y
flag.The ticket, which admittedly I wrote, says that the logged output shouldn't refer to 'deregistering' stacks (but should just use the word 'delete') but on further consideration I think that's maybe not a smart idea and will be confusing (primarily for us). As long as we retain the concepts of 'registering' and 'deregistering' inside the repo and stack stores, we probably should retain that language.
Pre-requisites
Please ensure you have done the following:
Types of changes