Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stack delete confirmation prompt #548

Merged
merged 5 commits into from
Apr 29, 2022

Conversation

strickvl
Copy link
Contributor

@strickvl strickvl commented Apr 29, 2022

Describe changes

I added a confirmation check prior to stack deletion. You can do a 'force' delete (i.e. without confirmation) by passing in a -y flag.

The ticket, which admittedly I wrote, says that the logged output shouldn't refer to 'deregistering' stacks (but should just use the word 'delete') but on further consideration I think that's maybe not a smart idea and will be confusing (primarily for us). As long as we retain the concepts of 'registering' and 'deregistering' inside the repo and stack stores, we probably should retain that language.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@strickvl strickvl added enhancement New feature or request internal To filter out internal PRs and issues labels Apr 29, 2022
@strickvl strickvl requested review from htahir1 and schustmi April 29, 2022 09:08
Copy link
Contributor

@schustmi schustmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great feature and nice to have a small PR for a change! :)

I left two comments which are my personal code style preferences and in no way change the behavior of the code, feel free to ignore them or update the PR if you agree with them

Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🪨 !

@strickvl strickvl merged commit e0337da into develop Apr 29, 2022
@strickvl strickvl deleted the feature/ENG-694-stack-delete-confirmation branch April 29, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants