Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/optional-secrets-manager #493

Merged
merged 12 commits into from
Apr 8, 2022
Merged

bugfix/optional-secrets-manager #493

merged 12 commits into from
Apr 8, 2022

Conversation

safoinme
Copy link
Contributor

@safoinme safoinme commented Apr 4, 2022

Describe changes

  1. Change secrets manager to optional instead of required when working with Kubeflow orchestrator, since secrets manager are optional the Kubeflow orchestrator will raise an error only if the user provides secrets while secrets-manager is not set in the active stack.

  2. Adding environment_vars to generate docker file function because it was missing.

image

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@safoinme safoinme requested review from htahir1 and alex-zenml April 4, 2022 02:38
@github-actions github-actions bot added internal To filter out internal PRs and issues bug Something isn't working labels Apr 4, 2022
htahir1
htahir1 requested changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just left some comments :-)

src/zenml/integrations/kubeflow/orchestrators/kubeflow_orchestrator.py Show resolved Hide resolved
src/zenml/utils/docker_utils.py Show resolved Hide resolved
@safoinme safoinme requested review from strickvl and htahir1 April 7, 2022 11:45
@strickvl strickvl removed the request for review from alex-zenml April 7, 2022 11:54
strickvl
strickvl requested changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@strickvl strickvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two tiny things... Otherwise good to go from my side...

src/zenml/integrations/kubeflow/orchestrators/kubeflow_orchestrator.py Outdated Show resolved Hide resolved
src/zenml/utils/docker_utils.py Outdated Show resolved Hide resolved
htahir1
htahir1 approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a go from my side!

@safoinme safoinme requested a review from strickvl April 7, 2022 15:18
strickvl
strickvl approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@strickvl strickvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@safoinme safoinme requested a review from strickvl April 8, 2022 10:41
@safoinme
Merge branch 'develop' into bugfix/optional-secrets-manager
9beedf4 
Merge branch 'develop' into 'bugfix/optional-secrets-manager'
@safoinme safoinme merged commit 483ad2e into develop Apr 8, 2022
@safoinme safoinme deleted the bugfix/optional-secrets-manager branch April 8, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htahir1 htahir1 htahir1 approved these changes

@strickvl strickvl strickvl approved these changes

Assignees
No one assigned
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@safoinme @strickvl @htahir1