Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zenml stack describe bug #476

Merged
merged 4 commits into from
Mar 24, 2022
Merged

Fix zenml stack describe bug #476

merged 4 commits into from
Mar 24, 2022

Conversation

strickvl
Copy link
Contributor

Describe changes

Fixed the bug on the zenml stack describe command caused by a change in what was passed into the print/output function.
Added a test to check for that going forward.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@strickvl strickvl added bug Something isn't working internal To filter out internal PRs and issues labels Mar 24, 2022
@strickvl strickvl requested a review from htahir1 March 24, 2022 05:42
htahir1
htahir1 reviewed Mar 24, 2022
View reviewed changes
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok looks good! Just a few comments

tests/unit/cli/test_utils.py Show resolved Hide resolved
src/zenml/steps/base_step.py Show resolved Hide resolved
@strickvl strickvl requested a review from stefannica March 24, 2022 06:27
@strickvl
Copy link
Contributor Author

@stefannica adding you on this as you said you've already fixed this.

stefannica
stefannica reviewed Mar 24, 2022
View reviewed changes
src/zenml/cli/utils.py Outdated Show resolved Hide resolved
@strickvl strickvl requested a review from htahir1 March 24, 2022 07:57
htahir1
htahir1 approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTm!

@strickvl strickvl merged commit 71c3b71 into develop Mar 24, 2022
@strickvl strickvl deleted the bugfix/describe-cli-letter-splitting branch March 24, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htahir1 htahir1 htahir1 approved these changes

@stefannica stefannica stefannica approved these changes

Assignees
No one assigned
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@strickvl @stefannica @htahir1